Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix three date/time issues in spec #63

Merged
merged 5 commits into from
May 12, 2020
Merged

Fix three date/time issues in spec #63

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
21ec23f
Drop null dateformat
vinceatbluelabs May 11, 2020
cd7d3a6
Provide "YYYY-MM-DD HH:MI:SS" as a valid datetimeformat
vinceatbluelabs May 11, 2020
474b0e3
Remove redundant valid value for datetimeformattz
vinceatbluelabs May 11, 2020
bcdd553
Merge branch 'master' into spec_fixes
vinceatbluelabs May 11, 2020
ed2e38f
Merge branch 'master' into spec_fixes
vinceatbluelabs May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions docs/RECORDS_SPEC.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,13 +244,9 @@ configuration provided to it outside of this spec).

Default value is `"UTF8"`

* `dateformat`: Valid values: `null`, `"YYYY-MM-DD"`, `"MM-DD-YYYY"`,
* `dateformat`: Valid values: `"YYYY-MM-DD"`, `"MM-DD-YYYY"`,
`"DD-MM-YYYY"`, `"MM/DD/YY"`.

`null` implies that that date format is unknown, and that the
implementation SHOULD generate using their default value and parse
permissively.

See
[Redshift docs](https://docs.aws.amazon.com/redshift/latest/dg/r_DATEFORMAT_and_TIMEFORMAT_strings.html)
for more information.
Expand All @@ -268,7 +264,7 @@ configuration provided to it outside of this spec).

* `datetimeformattz`: Valid values: `"YYYY-MM-DD HH:MI:SSOF"`,
`"YYYY-MM-DD HH:MI:SS"`, `"YYYY-MM-DD HH24:MI:SSOF"`,
`"YYYY-MM-DD HH24:MI:SSOF"`, `"MM/DD/YY HH24:MI"`. See
and `"MM/DD/YY HH24:MI"`. See
[Redshift docs](https://docs.aws.amazon.com/redshift/latest/dg/copy-parameters-data-conversion.html#copy-timeformat)
for more information (note that `HH:` is equivalent to `HH24:` and
that if you don't provide an offset (`OF`), times are assumed to be
Expand All @@ -277,10 +273,12 @@ configuration provided to it outside of this spec).
Default value is `"YYYY-MM-DD HH:MI:SSOF"`.

* `datetimeformat`: Valid values: `"YYYY-MM-DD HH24:MI:SS"`,
`"YYYY-MM-DD HH12:MI AM"`, `"MM/DD/YY HH24:MI"`.
`"YYYY-MM-DD HH:MI:SS"`, `"YYYY-MM-DD HH12:MI AM"`, `"MM/DD/YY HH24:MI"`.
See
[Redshift docs](https://docs.aws.amazon.com/redshift/latest/dg/copy-parameters-data-conversion.html#copy-timeformat)
for more information.
for more information (note that `HH:` is equivalent to `HH24:` and
that if you don't provide an offset (`OF`), times are assumed to be
in UTC).

Default value is `"YYYY-MM-DD HH:MI:SS"`.

Expand Down