Fix three date/time issues in spec #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While being able to specify 'please permissively parse' and 'use a default value' may be helpful, neither is implemented in records mover and 'null' is not defined in the other date and/or time hints.
It's redundant yes, but already being used in our bigquery format and understood natively by Redshift.
cwegrzyn
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These things were found while converting the spec into Literal[] types:
Drop null dateformat
While being able to specify 'please permissively parse' and 'use a
default value' may be helpful, neither is implemented in records mover
and 'null' is not defined in the other date and/or time hints.
Provide "YYYY-MM-DD HH:MI:SS" as a valid datetimeformat
It's redundant yes, but already being used in our bigquery format as the default value and
understood natively by Redshift.
Remove redundant valid value for datetimeformattz