Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keepalives by default to redshift db connection url #173

Merged
merged 7 commits into from
Dec 13, 2022

Conversation

austinweisgrau
Copy link
Contributor

These seem to prevent issues with long queries timing out. I couldn't find any great documentation about this, only this stackoverload thread and my own experimentation.

https://stackoverflow.com/q/43594310/18421950

These seem to prevent issues with long queries timing out.
I couldn't find any great documentation about this, only this
stackoverload thread and my own experimentation.

https://stackoverflow.com/q/43594310/18421950
@ryantimjohn
Copy link
Contributor

@austinweisgrau sorry it took me so long to review but seems like a very reasonable change; record mover is not building currently (see https://circleci.com/gh/bluelabsio/records-mover/16903 ) so we'll have to correct issue with nose-progressive not installing to be able to push this change out to people through Alectrona.

@ryantimjohn
Copy link
Contributor

Seems like @archetypalsxe (Jack) was working on this before he left:
#171

@jessezlotoff
Copy link

Here's some AWS info for reference: https://docs.aws.amazon.com/redshift/latest/mgmt/connecting-firewall-guidance.html. Pretty sure that the default is 5 mins so anything under that should avoid the issue.

@archetypalsxe
Copy link
Contributor

Seems like @archetypalsxe (Jack) was working on this before he left: #171

👋 I'm still consulting with BlueLabs! I might be looking back into this soon, there was just a shift of priorities and I ended up working on a bunch of other stuff. The biggest thing preventing us from upgrading to Airflow 2 is the build failing and trying to get that going again

@ryantimjohn
Copy link
Contributor

Seems like @archetypalsxe (Jack) was working on this before he left: #171

👋 I'm still consulting with BlueLabs! I might be looking back into this soon, there was just a shift of priorities and I ended up working on a bunch of other stuff. The biggest thing preventing us from upgrading to Airflow 2 is the build failing and trying to get that going again

Shifting priorities? I don't believe it =p

Is there anything we can help on with the breaking build that you're trying to fix with #171 ? Happy to scrub in if it'd be helpful.

@ryantimjohn
Copy link
Contributor

All tests passing, going to merge

@ryantimjohn ryantimjohn merged commit f2483d2 into master Dec 13, 2022
@ryantimjohn ryantimjohn deleted the keepalives branch December 13, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants