New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Nose-Progressive Dependency #171

Merged

ryantimjohn merged 68 commits into master from airflow-2

Dec 12, 2022

Contributor

archetypalsxe commented Apr 8, 2022

No description provided.

archetypalsxe added 9 commits

April 8, 2022 15:52


          Added a try/catch around the Airflow BaseHook import to add

fd9e44f

compatibility with Airflow 2.0


          Removing nose-requirements from the requirements.txt due to breaking the

fc0166d

Circle CI build and it's a purely cosmetic change for test


          Specifying the version of markupsafe to use due to CircleCI

f9f8f8d


          Downgrading Pandas to get around Overflow Error in Circle CI

3f4d05c


          Trying to update the Pandas dependency in setup.py to require

c28e2df

specifically Pandas 1.3.5 (is removing 1.3.5 in favor of 1.4.2)


          Updating the CircleCI config so that it tests with specifically Pandas

ca4a13f

1.3.5


          Correcting syntax for specifying Pandas 1.3.5 in the CircleCI config

d1a81b8


          Updating the lower code coverage high water mark

a5eccc6


          Attempting to resolve CircleCI Python MyPy checks

9623cec

bluelabsbutler reviewed

View reviewed changes

records_mover/records/mover.py Outdated Show resolved Hide resolved

archetypalsxe added 2 commits

April 8, 2022 17:06


          Correcting MyPy lint error

665d875


          Switching from noqa to type: ignore for MyPy in Circle CI

ba686d6

bluelabsbutler reviewed

View reviewed changes

records_mover/airflow/hooks/records_hook.py Outdated Show resolved Hide resolved

bluelabsbutler reviewed

View reviewed changes

records_mover/airflow/hooks/sqlalchemy_db_hook.py Outdated Show resolved Hide resolved

bluelabsbutler reviewed

View reviewed changes

records_mover/records/mover.py Outdated Show resolved Hide resolved

bluelabsbutler reviewed

View reviewed changes

records_mover/records/mover.py Outdated Show resolved Hide resolved

bluelabsbutler reviewed

View reviewed changes

records_mover/records/targets/google_sheets.py Outdated Show resolved Hide resolved

archetypalsxe added 4 commits

April 8, 2022 17:16


          Correcting formatting errors

5549e7c


          Increasing mypy high water mark

d16609d


          Probably shouldn't be doing this... but trying to get Circle CI to

ae8e45e

work...

Adding google-cloud-storage to the requirements to make sure that it's
installed


          Updating expected column types in the unit tests to look for

d07c0e0

"TIMESTAMPTZ" rather than "TIMESTAMP WITH TIME ZONE"

ryantimjohn mentioned this pull request

Add keepalives by default to redshift db connection url #173

Merged

archetypalsxe added 4 commits

October 18, 2022 16:27


          Removing #type: ignore comment due to getting an error in CircleCI about

422b24c

it being unused


          Trying to downgrade Pandas to version 1.1.5 rather than 1.3.5 (CircleCI

cd3bc4f

is saying it can't find version 1.3.5, and 1.1.5 is the newest version
it lists as being available)


          Downgrading to Pandas 1.1.5 in the requirements.txt file as well

786551c


          Downgrading pandas to 1.1.5 in setup.py as well

d72dd62

ryantimjohn mentioned this pull request

Handle exception when machine has no np.float128 #174

Merged

Contributor

ryantimjohn commented Dec 5, 2022

I'm going to take this on and try and get the CircleCI tests above to pass!

ryantimjohn added 2 commits

December 5, 2022 16:35


          add boto3 to requirements.txt

3f02d49


          fix failing tests

b9563b1

found here: https://circleci.com/api/v1.1/project/github/bluelabsio/records-mover/16991/output/108/0?file=true&allocation-id=638e6489707201559a3cf403-0-build%2F6855629B

ryantimjohn and others added 11 commits

December 9, 2022 10:48


          update postgres-itest pandas version to 1.3.5

065386d


          Updated config.yml

001aac3


          readd typecheck

021a822


          correctly format type ignore

11b3f39


          add two spaces before inline comment


          remove double end line

1cdf118


          reformat type ignore

ec21790


          add newline

ba2a835


          add type ignore to google cloud storage bucket

f3aabda


          add type ignore to table.py

132c2d8


          ratchet code coverage metric

90fcacb

ryantimjohn requested a review from mitchellj

December 9, 2022 16:58

Contributor

ryantimjohn commented Dec 9, 2022

Alright @mitchellj, I feel ready for this to be reviewed. Happy to talk through and explain any decisions made.


          ratchet flake8

c91383a

mitchellj approved these changes

View reviewed changes

ryantimjohn and others added 14 commits

December 10, 2022 15:16


          Updated config.yml

3e02b40


          add conditional for typecheck

417378c


          Updated config.yml

444e324


          Updated config.yml

fa1e03b


          Updated config.yml

1f3828d


          Updated config.yml

b1afebd


          Revert "Updated config.yml"

This reverts commit b1afebd.


          Revert "Updated config.yml"

5c789f7

This reverts commit 1f3828d.


          Revert "Updated config.yml"

108a798

This reverts commit fa1e03b.


          Revert "Updated config.yml"

bd0740b

This reverts commit 444e324.


          Revert "add conditional for typecheck"

09ac41a

This reverts commit 417378c.


          Updated config.yml

047e8c6


          remove install_dev_dependencies

a3d8384


          Merge branch 'master' into airflow-2

30351fc

ryantimjohn merged commit 1d7ee4b into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet