Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency fix for sudden BigQuery test failure #109

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Add dependency fix for sudden BigQuery test failure #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metrics/bigfiles_high_water_mark
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1015
1028
13 changes: 13 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,19 @@ def initialize_options(self) -> None:
#
# https://github.com/googleapis/google-auth-library-python/issues/190
'google-api-python-client>=1.8.0,<1.9.0',
#
vinceatbluelabs marked this conversation as resolved.
Show resolved Hide resolved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file, one of the 3 largest in the project, increased in size to 357 lines. The total size of those files is now 3399 lines (target: 1028). Is this file complex enough to refactor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we established you really can't break up stuff in setup.py without breaking some different packaging scenarios.

# For some reason this issue started happening consistently around 2020-10:
#
# https://app.circleci.com/pipelines/github/bluelabsio/records-mover/1134/workflows/267ca651-def1-4f60-bdfb-0f857a9e0c60/jobs/9770
#
# This seems to be a clue:
#
# https://github.com/pypa/pip/issues/8407
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praying for the new resolution stuff to be out and stable soon-- although i'm sure it's going to break all sorts of back/forwards compatibility things, sigh.

#
# However, downgrading pip does not seem to resolve it, so it
# doesn't seem to have been caused by a pip upgrade. For now
# we'll explicitly state the dependency for force the install:
'grpcio<2.0dev,>=1.29.0',
]

nose_dependencies = [
Expand Down