Add dependency fix for sudden BigQuery test failure #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -105,6 +105,19 @@ def initialize_options(self) -> None: | |||
| # | |||
| # https://github.com/googleapis/google-auth-library-python/issues/190 | |||
| 'google-api-python-client>=1.8.0,<1.9.0', | |||
| # | |||
There was a problem hiding this comment.
This file, one of the 3 largest in the project, increased in size to 357 lines. The total size of those files is now 3399 lines (target: 1028). Is this file complex enough to refactor?
There was a problem hiding this comment.
Unfortunately we established you really can't break up stuff in setup.py without breaking some different packaging scenarios.
cwegrzyn
reviewed
Oct 2, 2020
| # | ||
| # This seems to be a clue: | ||
| # | ||
| # https://github.com/pypa/pip/issues/8407 |
There was a problem hiding this comment.
Praying for the new resolution stuff to be out and stable soon-- although i'm sure it's going to break all sorts of back/forwards compatibility things, sigh.
Allow bigfile slip
vinceatbluelabs
force-pushed
the
new_google-api-core-dependency
branch
from
0fb1493 to
cb81f02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.