Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing pieces for new WebSocket URIs #393

Merged
merged 3 commits into from
May 8, 2018

Conversation

schnogz
Copy link
Contributor

@schnogz schnogz commented May 8, 2018

Description

  • Add all coin WebSocket URIs to default configuration for Express server.
  • Log all coin WebSocket configurations when Webpack and Express server starts.
  • Updates code coverage badge url to point to development branch

Change Type

Bug Fix, CI/CD

Testing Steps

N/A

PR Creator Checklist

  • Code compiles correctly
  • No lint issues exist (verified via yarn lint)
  • All unit tests pass (verified via yarn test)
  • Updated README.md and other documentation (if necessary)

PR Reviewer Checklist

  • Change validated and application spot checked
  • Code styles and best practices met
  • Code is readable and commented when necessary

@salomegeo
Copy link
Contributor

Is this all that was missing?

Do you think I might have made a mistake but adding configs and it would've been better to have this hacked in the code?

In general, do you think we can make it easier to change configs in future? I think this is worth considering, not sure if it's a priority right now.

@plondon
Copy link
Contributor

plondon commented May 8, 2018

I added some others yesterday: #386 and https://github.com/blockchain/blockchain-wallet-v4-frontend/pull/387/files. And a CI change was necessary. I think its okay to change things in wallet-options-v4.json generally, but we should be careful about anything the domains object, because that requires a few changes in different places.

@plondon plondon merged commit b85dfcf into development May 8, 2018
@plondon plondon deleted the feature/update-webpack-logger branch May 8, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants