Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Sockets): add new vars to dockerfile #386

Merged
merged 1 commit into from
May 7, 2018
Merged

Conversation

plondon
Copy link
Contributor

@plondon plondon commented May 7, 2018

Description

Add a concise explanation of the changes.

Change Type

Please enter one or more of the following:

  • Feature
  • Bug Fix
  • CI/CD
  • Upgrades
  • Other (add explanation)

Testing Steps

Detail the steps required for the reviewer(s) to verify and test these changes.

PR Creator Checklist

  • Code compiles correctly
  • No lint issues exist (verified via yarn lint)
  • All unit tests pass (verified via yarn test)
  • Updated README.md and other documentation (if necessary)

PR Reviewer Checklist

  • Change validated and application spot checked
  • Code styles and best practices met
  • Code is readable and commented when necessary

@plondon plondon requested a review from schnogz May 7, 2018 17:18
@prwelber prwelber requested review from prwelber and removed request for prwelber May 7, 2018 17:32
@plondon plondon merged commit 19e4b25 into development May 7, 2018
@plondon plondon deleted the hotfix/sockets branch May 7, 2018 17:33
@plondon plondon mentioned this pull request May 8, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants