Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable wrapcheck for new code #1896

Merged
merged 1 commit into from
Jun 27, 2024
Merged

chore: enable wrapcheck for new code #1896

merged 1 commit into from
Jun 27, 2024

Conversation

alecthomas
Copy link
Collaborator

This has been disabled because manually wrapping all errors is very tedious when iterating quickly, but it's come to the point where we need to do this in order to provide useful errors. Recent examples of this are #1885 and #1879.

@alecthomas alecthomas requested review from a team and wesbillman and removed request for a team June 27, 2024 10:16
@ftl-robot ftl-robot mentioned this pull request Jun 27, 2024
@alecthomas alecthomas force-pushed the aat/wrapcheck branch 4 times, most recently from 07132c2 to 4b4833d Compare June 27, 2024 10:57
This has been disabled because manually wrapping all errors is very
tedious when iterating quickly, but it's come to the point where we need
to do this in order to provide useful errors. Recent examples of this
are #1885 and
#1879.
@alecthomas alecthomas merged commit 9f48c74 into main Jun 27, 2024
43 checks passed
@alecthomas alecthomas deleted the aat/wrapcheck branch June 27, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant