Skip to content

Commit

Permalink
chore: enable wrapcheck for new code (#1896)
Browse files Browse the repository at this point in the history
This has been disabled because manually wrapping all errors is very
tedious when iterating quickly, but it's come to the point where we need
to do this in order to provide useful errors. Recent examples of this
are #1885 and
#1879.
alecthomas authored Jun 27, 2024

Verified

This commit was signed with the committer’s verified signature.
Exirel Florian Strzelecki
1 parent e4bba48 commit 9f48c74
Showing 3 changed files with 4 additions and 3 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -58,12 +58,14 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Init Hermit
uses: cashapp/activate-hermit@v1
- name: Build Cache
uses: ./.github/actions/build-cache
- name: golangci-lint
run: golangci-lint run --out-format github-actions ./...
run: golangci-lint run --new-from-rev="$(git merge-base origin/main HEAD)" --out-format github-actions ./...
- name: go-check-sumtype
shell: bash
run: go-check-sumtype ./... 2>&1 | to-annotation
1 change: 0 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
@@ -57,7 +57,6 @@ linters:
- interfacebloat
- tagalign
- nolintlint
- wrapcheck # We might want to re-enable this if we manually wrap all the existing errors with fmt.Errorf
- protogetter

linters-settings:
2 changes: 1 addition & 1 deletion Justfile
Original file line number Diff line number Diff line change
@@ -139,7 +139,7 @@ lint-frontend: build-frontend

# Lint the backend
lint-backend:
@golangci-lint run ./...
@golangci-lint run --new-from-rev=$(git merge-base origin/main HEAD) ./...

# Run live docs server
docs:

0 comments on commit 9f48c74

Please sign in to comment.