Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log http ingress server address #1620

Merged
merged 2 commits into from
Jun 2, 2024
Merged

feat: log http ingress server address #1620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e81808c
log http ingress server address
mistermoe Jun 2, 2024
9ac2b40
update command in `CONTRIBUTING.md`
mistermoe Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Once the Hermit environment is activated you can type the following to start a
hot-reloading ftl agent:

```
$ ftl dev ./examples/go
$ ftl dev --recreate ./examples/go
```

## Development processes
Expand Down
2 changes: 2 additions & 0 deletions backend/controller/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,8 @@ func Start(ctx context.Context, config Config, runnerScaling scaling.RunnerScali

g, ctx := errgroup.WithContext(ctx)
g.Go(func() error {
logger.Infof("HTTP ingress server listening on: %s", config.IngressBind)

return ftlhttp.Serve(ctx, config.IngressBind, ingressHandler)
})

Expand Down
Loading