Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log http ingress server address #1620

Merged
merged 2 commits into from
Jun 2, 2024
Merged

feat: log http ingress server address #1620

merged 2 commits into from
Jun 2, 2024

Conversation

mistermoe
Copy link
Collaborator

Warning

Highly controversial PR.

JK 😄

I recently bumped ftl in two projects and had to come look at what was merged recently to figure out where the http ingress server is listening. Thought it might be helpful to add an info log that prints the address so that folks know where it's running.

Feel free to close this out if it's not desired!

❯ ftl dev --recreate ./examples/go
info: Starting FTL with 1 controller(s)
info:controller0: Web console available at: http://localhost:8892
info:controller0: HTTP ingress server listening on: http://localhost:8891
info: FTL startup command ⚡️
info:time: Building module
info:time: Deploying module
info:echo: Building module
info:echo: Deploying module
info:controller0: Deployed dpl-time-2kwcynci5qht7uyh
info:controller0: Deployed dpl-echo-bzjm9re0dy2kpjq
info: All modules deployed, watching for changes...

@mistermoe mistermoe requested a review from alecthomas as a code owner June 2, 2024 04:11
@mistermoe mistermoe requested review from a team and worstell and removed request for a team June 2, 2024 04:11
@github-actions github-actions bot changed the title log http ingress server address feat: log http ingress server address Jun 2, 2024
@alecthomas alecthomas merged commit ea7c1e0 into main Jun 2, 2024
28 checks passed
@alecthomas alecthomas deleted the http-ingress-log branch June 2, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants