Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit shm frame count #12363

Merged
merged 15 commits into from
Sep 3, 2024
Merged

Limit shm frame count #12363

merged 15 commits into from
Sep 3, 2024

Conversation

NickM-27
Copy link
Collaborator

@NickM-27 NickM-27 commented Jul 9, 2024

The capture process is in charge of deleting frames from SHM meaning downstream processes that may fail won't cause SHM to overflow

@NickM-27 NickM-27 marked this pull request as ready for review July 10, 2024 12:41
@NickM-27 NickM-27 marked this pull request as draft July 10, 2024 19:22
@NickM-27 NickM-27 force-pushed the 0.14.1 branch 2 times, most recently from 5a0c83b to 8ce9297 Compare July 13, 2024 16:59
@NickM-27 NickM-27 force-pushed the 0.14.1 branch 4 times, most recently from b3a3939 to 0794624 Compare July 24, 2024 18:29
@NickM-27 NickM-27 force-pushed the 0.14.1 branch 2 times, most recently from 157df74 to 315f26b Compare July 29, 2024 12:58
@NickM-27 NickM-27 force-pushed the 0.15 branch 4 times, most recently from 695f64f to bdb50ba Compare August 14, 2024 14:51
@NickM-27 NickM-27 force-pushed the 0.15 branch 3 times, most recently from 47440e0 to bf11ae3 Compare August 23, 2024 13:01
Base automatically changed from 0.15 to dev August 30, 2024 02:19
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit bcfd13f
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/66d735d9764b130008432cd7

@NickM-27 NickM-27 marked this pull request as ready for review September 3, 2024 14:51
@NickM-27 NickM-27 requested a review from hawkeye217 September 3, 2024 14:51
* Only keep 2x detect fps frames in SHM

* Don't delete previous shm frames in output

* Catch case where images do not exist

* Ensure files are closed

* Clear out all frames when shutting down

* Correct the number of frames saved

* Simplify empty shm error handling

* Improve frame safety
@NickM-27 NickM-27 merged commit 9afa135 into dev Sep 3, 2024
13 checks passed
@NickM-27 NickM-27 deleted the fix-shm branch September 3, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants