Limited shm frame count #12346
Merged
Limited shm frame count #12346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs canceled.
|
blakeblackshear
approved these changes
Jul 9, 2024
|
This causes my SHM to run out immediately on startup, no errors in the logs except no space available, reverting to previous build fixes issue |
|
how much SHM do you have available and what are the detect fps? |
|
shm_size: "1521mb" Honestly, thinking about it I might need to recalculate based off the guide of what it should be, I might have added cameras since then, but I've had 0 zero issues before this. |
|
there is but technically we did not update that calculation for this, not 100% sure if things changed. I am also seeing issues but not like you are describing, it is just having a lot of missed frames |
hawkeye217
added a commit
that referenced
this pull request
Jul 9, 2024
This reverts commit 34812b7.
hawkeye217
pushed a commit
that referenced
this pull request
Jul 9, 2024
NickM-27
added a commit
that referenced
this pull request
Jul 9, 2024
* Only keep 2x detect fps frames in SHM * Don't delete previous shm frames in output * Catch case where images do not exist * Ensure files are closed * Clear out all frames when shutting down * Correct the number of frames saved * Simplify empty shm error handling * Improve frame safety
NickM-27
added a commit
that referenced
this pull request
Sep 2, 2024
* Only keep 2x detect fps frames in SHM * Don't delete previous shm frames in output * Catch case where images do not exist * Ensure files are closed * Clear out all frames when shutting down * Correct the number of frames saved * Simplify empty shm error handling * Improve frame safety
NickM-27
added a commit
that referenced
this pull request
Sep 3, 2024
* Only keep 2x detect fps frames in SHM * Don't delete previous shm frames in output * Catch case where images do not exist * Ensure files are closed * Clear out all frames when shutting down * Correct the number of frames saved * Simplify empty shm error handling * Improve frame safety
NickM-27
added a commit
that referenced
this pull request
Sep 3, 2024
* Only keep 2x detect fps frames in SHM * Don't delete previous shm frames in output * Catch case where images do not exist * Ensure files are closed * Clear out all frames when shutting down * Correct the number of frames saved * Simplify empty shm error handling * Improve frame safety
NickM-27
added a commit
that referenced
this pull request
Sep 3, 2024
* Limited shm frame count (#12346) * Only keep 2x detect fps frames in SHM * Don't delete previous shm frames in output * Catch case where images do not exist * Ensure files are closed * Clear out all frames when shutting down * Correct the number of frames saved * Simplify empty shm error handling * Improve frame safety * Add handler logs when frame is None * Don't fail on cleanup * Cleanup logging * Update docs * Update calculation * Restore condition * Fix case where thumbnail is saved without frame * Adjust debug logs * Calculate best shm frame count * Fix shm count calculation * Catch missing frame * Formatting * Clarify docs * Catch none frame in autotracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simpler approach to #12020 which has the capture process clean up SHM frames automatically to ensure the SHM will not overflow.