-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-2436] Show unassigned items banner in browser #8656
[AC-2436] Show unassigned items banner in browser #8656
Conversation
…-unassigned-ciphers
…-ciphers' into ac/ac-2436/new-banner-for-organizations-with-unassigned-ciphers-browser
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8656 +/- ##
==========================================
+ Coverage 27.21% 27.22% +0.01%
==========================================
Files 2338 2339 +1
Lines 68230 68254 +24
Branches 12742 12746 +4
==========================================
+ Hits 18567 18582 +15
- Misses 48268 48276 +8
- Partials 1395 1396 +1 ☔ View full report in Codecov by Sentry. |
New Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for team vault.
Looks like there are some linting issues |
a613856
to
c2f1650
Compare
3b58781
to
c2f1650
Compare
…-unassigned-ciphers-browser
* Boostrap basic banner, show for all admins * Remove UI banner, fix method calls * Invert showBanner -> hideBanner * Add api call * Minor tweaks and wording * Change to active user state * Add tests * Fix mixed up names * Simplify logic * Add feature flag * Do not clear on logout * Show banner in browser as well * Update apps/browser/src/_locales/en/messages.json * Update copy --------- Co-authored-by: Addison Beck <[email protected]> Co-authored-by: Addison Beck <[email protected]> (cherry picked from commit 98ed744)
* Boostrap basic banner, show for all admins * Remove UI banner, fix method calls * Invert showBanner -> hideBanner * Add api call * Minor tweaks and wording * Change to active user state * Add tests * Fix mixed up names * Simplify logic * Add feature flag * Do not clear on logout * Show banner in browser as well * Update apps/browser/src/_locales/en/messages.json * Update copy --------- Co-authored-by: Addison Beck <[email protected]> Co-authored-by: Addison Beck <[email protected]> (cherry picked from commit 98ed744)
Type of change
Objective
Extend #8655 to browser.
It's stacked on #8655 as the web vault is the main priority, this can be reviewed and merged separately (after that one).
Notes:
Code changes
Screenshots
Before you submit