[AC-2436] Show unassigned items banner in web

[eliykat]

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Show a banner re: unassigned organization items if the user is an admin or owner of an org that has unassigned items.

Server PR: bitwarden/server#3967

Code changes

unassigned-items-banner.service.ts

This does the main work. It uses a single piece of state, SHOW_BANNER_KEY, to manage the banner:

• null -> the banner has not been shown to the user yet, check with the server whether we need to display it. This then updates the value which will trigger another run through the subscribe callback
• true -> show the banner
• false -> do not show the banner (because it has been dismissed or the server indicated it's not required)

Note that this is user state (because its value is computed per user) that is not cleared on logout (because we don't want to show them the banner again later). I'm checking with Platform Team that this is OK, because at the moment we don't have any way of looking this up later to clear it after the user has logged out.

Aside from this, it follows the same approach as web-layout-migration-banner.service.ts

Other changes

• add tests
• add new state definition
• add api call
• add feature flag (not discussed but seems prudent)

Screenshots

Before you submit

• Please add unit tests where it makes sense to do so (encouraged but not required)
• If this change requires a documentation update - notify the documentation team
• If this change has particular deployment requirements - notify the DevOps team
• Ensure that all UI additions follow WCAG AA requirements

[codecov]

Codecov Report

Attention: Patch coverage is 67.85714% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 27.21%. Comparing base (9d10825) to head (9688f69).
Report is 8 commits behind head on main.

Files	Patch %	Lines
...web/src/app/layouts/header/web-header.component.ts	50.00%	2 Missing and 1 partial ⚠️
...outs/header/web-unassigned-items-banner.service.ts	83.33%	2 Missing and 1 partial ⚠️
libs/common/src/services/api.service.ts	0.00%	2 Missing ⚠️
libs/common/src/enums/feature-flag.enum.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8655      +/-   ##
==========================================
- Coverage   27.22%   27.21%   -0.01%     
==========================================
  Files        2337     2338       +1     
  Lines       68114    68217     +103     
  Branches    12733    12738       +5     
==========================================
+ Hits        18543    18567      +24     
- Misses      48177    48255      +78     
- Partials     1394     1395       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – b1a43ee6-0aa2-44da-b830-912bad9ec1da

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Angular_Improper_Type_Pipe_Usage	/apps/web/src/app/layouts/header/web-header.component.html: 1	Attack Vector
	Angular_Improper_Type_Pipe_Usage	/apps/web/src/app/layouts/header/web-header.component.html: 1	Attack Vector

[shane-melton]

Is it intentional that we are completely replacing the "new web layout" banner? I would have thought we would keep that one and add the unassigned items banner below/above.

[addisonbeck]

@shane-melton yes, that's intentional. My understanding is that it was time for that banner to come down anyway.