Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-6978] Add menubar option for toggling hardware acceleration #8424

Merged
merged 4 commits into from
Mar 22, 2024

Merge branch 'main' into ps/PM-6978

8181236
Select commit
Loading
Failed to load commit list.
Merged

[PM-6978] Add menubar option for toggling hardware acceleration #8424

Merge branch 'main' into ps/PM-6978
8181236
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Mar 22, 2024 in 30s

CodeScene PR Check

Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method main.ts: Main.constructor

Annotations

Check warning on line 210 in apps/desktop/src/main.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

Main.constructor already has high cyclomatic complexity, and now it increases in Lines of Code from 133 to 134. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 97 in apps/desktop/src/main/menu/menubar.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Excess Number of Function Arguments

Menubar.constructor increases from 7 to 9 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.