Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-6978] Add menubar option for toggling hardware acceleration #8424

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Mar 21, 2024

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Follow up to #5968

Since some users are experiencing issues starting the application properly, I don't think we can rely on only having a setting inside the UI. This PR adds a troubleshooting menubar item which contains a "Disable hardware acceleration & restart" option.

Screenshots

image

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@Hinton Hinton marked this pull request as ready for review March 21, 2024 13:50
@Hinton Hinton requested a review from justindbaur March 21, 2024 13:50
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 26.40%. Comparing base (0f6d0e4) to head (5a1c372).

❗ Current head 5a1c372 differs from pull request most recent head 8181236. Consider uploading reports for the commit 8181236 to get more accurate results

Files Patch % Lines
apps/desktop/src/main/menu/menu.help.ts 0.00% 18 Missing ⚠️
apps/desktop/src/main/menu/menu.main.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8424      +/-   ##
==========================================
- Coverage   26.41%   26.40%   -0.01%     
==========================================
  Files        2290     2290              
  Lines       67091    67103      +12     
  Branches    12593    12593              
==========================================
+ Hits        17719    17720       +1     
- Misses      47990    48002      +12     
+ Partials     1382     1381       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

justindbaur
justindbaur previously approved these changes Mar 21, 2024
@Hinton Hinton removed the needs-qa Marks a PR as requiring QA approval label Mar 22, 2024
@Hinton Hinton merged commit ad588f1 into main Mar 22, 2024
23 checks passed
@Hinton Hinton deleted the ps/PM-6978 branch March 22, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants