Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault Strict Typing cleanup #12512

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

fix tests

3460ea1
Select commit
Loading
Failed to load commit list.
Open

Vault Strict Typing cleanup #12512

fix tests
3460ea1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 20, 2024 in 1s

33.68% (+0.08%) compared to 6ad35e0

View this Pull Request on Codecov

33.68% (+0.08%) compared to 6ad35e0

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.68%. Comparing base (6ad35e0) to head (3460ea1).
Report is 4 commits behind head on main.

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ault/src/components/copy-cipher-field.directive.ts 0.00% 2 Missing โš ๏ธ
...ault/src/components/password-reprompt.component.ts 0.00% 2 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12512      +/-   ##
==========================================
+ Coverage   33.60%   33.68%   +0.08%     
==========================================
  Files        2925     2921       -4     
  Lines       91455    91050     -405     
  Branches    17384    17255     -129     
==========================================
- Hits        30730    30667      -63     
+ Misses      58308    57996     -312     
+ Partials     2417     2387      -30     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.