Vault Strict Typing cleanup #12512
Open
Vault Strict Typing cleanup #12512
+25
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add null default value for class properties - Enforce that the userId is passed - noticeState$ can return null
- refactor title to be a string rather than null
- add guard to exit early on submit but also solves removing null/undefined from typing
- add bang for required types - add default values for null types
- add bang for required types - refactor title to be an empty string
nick-livefront
commented
Dec 20, 2024
| @@ -52,7 +50,7 @@ export class CopyCipherFieldDirective implements OnChanges { | |||
| @HostListener("click") | |||
| async copy() { | |||
| const value = this.getValueToCopy(); | |||
| await this.copyCipherFieldService.copy(value, this.action, this.cipher); | |||
| await this.copyCipherFieldService.copy(value ?? "", this.action, this.cipher); | |||
There was a problem hiding this comment.
❓ Should this throw an error rather than use a default value? I couldn't decide
|
New Issues
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12512 +/- ##
==========================================
+ Coverage 33.60% 33.68% +0.08%
==========================================
Files 2925 2921 -4
Lines 91455 91050 -405
Branches 17384 17255 -129
==========================================
- Hits 30730 30667 -63
+ Misses 58308 57996 -312
+ Partials 2417 2387 -30 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Objective
Another round of cleaning up some of the strict types in
libs/vault!to required inputs as stated in the decision document!within theCipherFormstories, these are a constant object for the stories so they're always defined.titleto match the needed type🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes