Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16233] Removing testing tabs and the learn more link #12481

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+0 −16
Open

[PM-16233] Removing testing tabs and the learn more link #12481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
939bdef
Removing testing tabs and the learn more link
ttalty Dec 19, 2024
be3e8f0
Merge branch 'main' into tools/pm-16233/testing-tab-removal-cleanup
ttalty Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions bitwarden_license/bit-web/src/app/tools/access-intelligence/risk-insights.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<h1 bitTypography="h1">{{ "riskInsights" | i18n }}</h1>
<div class="tw-text-muted tw-max-w-4xl tw-mb-2">
{{ "reviewAtRiskPasswords" | i18n }}
&nbsp;<a class="text-primary" routerLink="/login">{{ "learnMore" | i18n }}</a>
</div>
<div
class="tw-bg-primary-100 tw-rounded-lg tw-w-full tw-px-8 tw-py-4 tw-my-4 tw-flex tw-items-center"
Expand Down Expand Up @@ -45,14 +44,5 @@ <h1 bitTypography="h1">{{ "riskInsights" | i18n }}</h1>
</ng-template>
<tools-critical-applications></tools-critical-applications>
</bit-tab>
<bit-tab label="Raw Data">
<tools-password-health></tools-password-health>
</bit-tab>
<bit-tab label="Raw Data + members">
<tools-password-health-members></tools-password-health-members>
</bit-tab>
<bit-tab label="Raw Data + uri">
<tools-password-health-members-uri></tools-password-health-members-uri>
</bit-tab>
Comment on lines -48 to -56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing them, could we create a local flag (dev,qa) to enable them. I think we are going to find them useful in the future:

  • For QA during testing
  • or a user reporting that things are incorrect/missing on the All Applications report

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an example of how a dev/local flag would work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General info: https://contributing.bitwarden.com/contributing/feature-flags#flag-data-sources

An example for a devFlag would be the skipWelcomeOnInstall, which is used on browser.

The same works when using a simple flag on the web-client. Extend the environment json (base, development, qa) for your flagName and use the flagEnabled-function to retrieve it's value. The sdk flag being an example on web

</bit-tab-group>
</ng-container>
6 changes: 0 additions & 6 deletions bitwarden_license/bit-web/src/app/tools/access-intelligence/risk-insights.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ import { HeaderModule } from "@bitwarden/web-vault/app/layouts/header/header.mod
import { AllApplicationsComponent } from "./all-applications.component";
import { CriticalApplicationsComponent } from "./critical-applications.component";
import { NotifiedMembersTableComponent } from "./notified-members-table.component";
import { PasswordHealthMembersURIComponent } from "./password-health-members-uri.component";
import { PasswordHealthMembersComponent } from "./password-health-members.component";
import { PasswordHealthComponent } from "./password-health.component";

export enum RiskInsightsTabType {
AllApps = 0,
Expand All @@ -37,9 +34,6 @@ export enum RiskInsightsTabType {
CriticalApplicationsComponent,
JslibModule,
HeaderModule,
PasswordHealthComponent,
PasswordHealthMembersComponent,
PasswordHealthMembersURIComponent,
NotifiedMembersTableComponent,
TabsModule,
],
Expand Down
Loading