[PM-16233] Removing testing tabs and the learn more link #12481
Conversation
|
No New Or Fixed Issues Found |
| <bit-tab label="Raw Data"> | ||
| <tools-password-health></tools-password-health> | ||
| </bit-tab> | ||
| <bit-tab label="Raw Data + members"> | ||
| <tools-password-health-members></tools-password-health-members> | ||
| </bit-tab> | ||
| <bit-tab label="Raw Data + uri"> | ||
| <tools-password-health-members-uri></tools-password-health-members-uri> | ||
| </bit-tab> |
There was a problem hiding this comment.
Instead of removing them, could we create a local flag (dev,qa) to enable them. I think we are going to find them useful in the future:
- For QA during testing
- or a user reporting that things are incorrect/missing on the All Applications report
There was a problem hiding this comment.
Is there an example of how a dev/local flag would work?
There was a problem hiding this comment.
General info: https://contributing.bitwarden.com/contributing/feature-flags#flag-data-sources
An example for a devFlag would be the skipWelcomeOnInstall, which is used on browser.
The same works when using a simple flag on the web-client. Extend the environment json (base, development, qa) for your flagName and use the flagEnabled-function to retrieve it's value. The sdk flag being an example on web
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12481 +/- ##
=======================================
Coverage 33.59% 33.59%
=======================================
Files 2926 2926
Lines 91442 91439 -3
Branches 17376 17376
=======================================
+ Hits 30716 30723 +7
+ Misses 58311 58301 -10
Partials 2415 2415 ☔ View full report in Codecov by Sentry. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16233
📔 Objective
Removing the testing tabs and the learn more link.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes