-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13999] show estimated tax for taxable countries #12245
Merged
jonashendrickx
merged 53 commits into
main
from
PM-13999-Show-estimated-tax-for-taxable-countries
Jan 2, 2025
Merged
Changes from 2 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
1661320
[PM-14892] Refactoring tax estimation
jonashendrickx 52e7c26
[PM-14892] Refactoring tax estimation
jonashendrickx d786f50
wip
jonashendrickx bfafdf7
wip
jonashendrickx a125a8f
format
jonashendrickx fe2564a
useless code
jonashendrickx 2af08b8
Don't reset to 0 upon error
jonashendrickx 017017f
Merge branch 'main' into PM-14892-Sales-Tax-Estimation-For-Clients
jonashendrickx 2117d52
REFACTOR
jonashendrickx f1368cd
Merge remote-tracking branch 'origin/PM-14892-Sales-Tax-Estimation-Foโฆ
jonashendrickx 6c28363
Working for org creation
jonashendrickx 12a0382
Merge branch 'main' into PM-14891-Sales-Tax-Estimation-For-Organizations
jonashendrickx 4b264b6
wip
jonashendrickx 0014c22
Merge branch 'main' into PM-14892-Sales-Tax-Estimation-For-Clients
jonashendrickx 2588716
for old premium component
jonashendrickx 51ebe41
Merge branch 'PM-14892-Sales-Tax-Estimation-For-Clients' into PM-1399โฆ
jonashendrickx 6b97fb0
Merge branch 'PM-14891-Sales-Tax-Estimation-For-Organizations' into Pโฆ
jonashendrickx 0aa90e1
refactor
jonashendrickx fd9ec3f
refactor
jonashendrickx 81b7664
fix english translation tax id number
jonashendrickx 7a2e59b
refactor
jonashendrickx 63f85c7
refactor
jonashendrickx a1ed915
refactor
jonashendrickx f443708
refactor
jonashendrickx 4c5e734
refactor
jonashendrickx d2425ae
revert translation renaming
jonashendrickx 44c3bed
rename callback
jonashendrickx 6babfcd
Merge branch 'main' into PM-13999-Show-estimated-tax-for-taxable-counโฆ
jonashendrickx 83c3b7c
not correctly calculating total
jonashendrickx 3957a6c
reorder
jonashendrickx f0413bd
remove
jonashendrickx 974e070
Revert "remove"
jonashendrickx 0bcda6e
remove duplicate section
jonashendrickx e3a4baa
ChangePlanDialog now properly supports the sales tax being updated whโฆ
jonashendrickx 4dcb295
load state of adjust payment dialog
jonashendrickx d46cdf9
f
jonashendrickx 5313b3f
f
jonashendrickx 3f8e14e
f
jonashendrickx d9404c5
Merge branch 'main' into PM-13999-Show-estimated-tax-for-taxable-counโฆ
eliykat 34dccec
fix
jonashendrickx 541e239
Merge remote-tracking branch 'origin/PM-13999-Show-estimated-tax-for-โฆ
jonashendrickx e6686df
Merge branch 'refs/heads/main' into PM-13999-Show-estimated-tax-for-tโฆ
jonashendrickx 6041e32
fix
jonashendrickx 9ba70ab
Merge branch 'main' into PM-13999-Show-estimated-tax-for-taxable-counโฆ
jonashendrickx 64e3598
PM-16195
jonashendrickx cd566de
Merge remote-tracking branch 'origin/PM-13999-Show-estimated-tax-for-โฆ
jonashendrickx ba0596b
Merge branch 'main' into PM-13999-Show-estimated-tax-for-taxable-counโฆ
jonashendrickx 7ffbdf4
exclude personal plans from entering tax id
jonashendrickx ec46ffe
Merge branch 'main' into PM-13999-Show-estimated-tax-for-taxable-counโฆ
jonashendrickx 8736c4c
Fix bug
jonashendrickx fb3b6c2
Show validation error correctly
jonashendrickx f12aaf4
fix bug
jonashendrickx 5570a0f
fix formatting
jonashendrickx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ค I don't think component library forms require these kinds of workarounds (
markAllAsTouched
). You should just be able to check the formgroup's valid state. Maybe double check whether it's necessary and ask the design team.