Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13999] show estimated tax for taxable countries #12245

Merged
Merged
Changes from 2 commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
1661320
[PM-14892] Refactoring tax estimation
jonashendrickx Nov 14, 2024
52e7c26
[PM-14892] Refactoring tax estimation
jonashendrickx Nov 18, 2024
d786f50
wip
jonashendrickx Nov 20, 2024
bfafdf7
wip
jonashendrickx Nov 20, 2024
a125a8f
format
jonashendrickx Nov 20, 2024
fe2564a
useless code
jonashendrickx Nov 20, 2024
2af08b8
Don't reset to 0 upon error
jonashendrickx Nov 20, 2024
017017f
Merge branch 'main' into PM-14892-Sales-Tax-Estimation-For-Clients
jonashendrickx Nov 20, 2024
2117d52
REFACTOR
jonashendrickx Nov 20, 2024
f1368cd
Merge remote-tracking branch 'origin/PM-14892-Sales-Tax-Estimation-Foโ€ฆ
jonashendrickx Nov 20, 2024
6c28363
Working for org creation
jonashendrickx Nov 21, 2024
12a0382
Merge branch 'main' into PM-14891-Sales-Tax-Estimation-For-Organizations
jonashendrickx Nov 22, 2024
4b264b6
wip
jonashendrickx Nov 22, 2024
0014c22
Merge branch 'main' into PM-14892-Sales-Tax-Estimation-For-Clients
jonashendrickx Nov 22, 2024
2588716
for old premium component
jonashendrickx Nov 22, 2024
51ebe41
Merge branch 'PM-14892-Sales-Tax-Estimation-For-Clients' into PM-1399โ€ฆ
jonashendrickx Nov 25, 2024
6b97fb0
Merge branch 'PM-14891-Sales-Tax-Estimation-For-Organizations' into Pโ€ฆ
jonashendrickx Nov 25, 2024
0aa90e1
refactor
jonashendrickx Nov 25, 2024
fd9ec3f
refactor
jonashendrickx Nov 26, 2024
81b7664
fix english translation tax id number
jonashendrickx Nov 26, 2024
7a2e59b
refactor
jonashendrickx Nov 26, 2024
63f85c7
refactor
jonashendrickx Nov 26, 2024
a1ed915
refactor
jonashendrickx Nov 26, 2024
f443708
refactor
jonashendrickx Nov 26, 2024
4c5e734
refactor
jonashendrickx Nov 26, 2024
d2425ae
revert translation renaming
jonashendrickx Nov 26, 2024
44c3bed
rename callback
jonashendrickx Nov 26, 2024
6babfcd
Merge branch 'main' into PM-13999-Show-estimated-tax-for-taxable-counโ€ฆ
jonashendrickx Nov 26, 2024
83c3b7c
not correctly calculating total
jonashendrickx Nov 26, 2024
3957a6c
reorder
jonashendrickx Nov 27, 2024
f0413bd
remove
jonashendrickx Nov 28, 2024
974e070
Revert "remove"
jonashendrickx Nov 28, 2024
0bcda6e
remove duplicate section
jonashendrickx Nov 28, 2024
e3a4baa
ChangePlanDialog now properly supports the sales tax being updated whโ€ฆ
jonashendrickx Nov 28, 2024
4dcb295
load state of adjust payment dialog
jonashendrickx Dec 2, 2024
d46cdf9
f
jonashendrickx Dec 3, 2024
5313b3f
f
jonashendrickx Dec 3, 2024
3f8e14e
f
jonashendrickx Dec 3, 2024
d9404c5
Merge branch 'main' into PM-13999-Show-estimated-tax-for-taxable-counโ€ฆ
eliykat Dec 5, 2024
34dccec
fix
jonashendrickx Dec 11, 2024
541e239
Merge remote-tracking branch 'origin/PM-13999-Show-estimated-tax-for-โ€ฆ
jonashendrickx Dec 11, 2024
e6686df
Merge branch 'refs/heads/main' into PM-13999-Show-estimated-tax-for-tโ€ฆ
jonashendrickx Dec 11, 2024
6041e32
fix
jonashendrickx Dec 11, 2024
9ba70ab
Merge branch 'main' into PM-13999-Show-estimated-tax-for-taxable-counโ€ฆ
jonashendrickx Dec 11, 2024
64e3598
PM-16195
jonashendrickx Dec 19, 2024
cd566de
Merge remote-tracking branch 'origin/PM-13999-Show-estimated-tax-for-โ€ฆ
jonashendrickx Dec 19, 2024
ba0596b
Merge branch 'main' into PM-13999-Show-estimated-tax-for-taxable-counโ€ฆ
jonashendrickx Dec 19, 2024
7ffbdf4
exclude personal plans from entering tax id
jonashendrickx Dec 23, 2024
ec46ffe
Merge branch 'main' into PM-13999-Show-estimated-tax-for-taxable-counโ€ฆ
jonashendrickx Dec 23, 2024
8736c4c
Fix bug
jonashendrickx Dec 26, 2024
fb3b6c2
Show validation error correctly
jonashendrickx Dec 27, 2024
f12aaf4
fix bug
jonashendrickx Dec 30, 2024
5570a0f
fix formatting
jonashendrickx Dec 31, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,14 @@ export class ManageTaxInformationComponent implements OnInit, OnDestroy {
this.taxInformationUpdated.emit();
};

validate = (): boolean => {
this.formGroup.markAllAsTouched();
return this.formGroup.valid;
};
validate(): boolean {
if (this.formGroup.dirty) {
this.formGroup.markAllAsTouched();
return this.formGroup.valid;
} else {
return this.formGroup.valid;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿค” I don't think component library forms require these kinds of workarounds (markAllAsTouched). You should just be able to check the formgroup's valid state. Maybe double check whether it's necessary and ask the design team.


async ngOnInit() {
if (this.startWith) {
Expand Down
Loading