[PM-13999] show estimated tax for taxable countries #12245
Merged
+1,187
−1,245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-Clients' into PM-14892-Sales-Tax-Estimation-For-Clients
…9-Show-estimated-tax-for-taxable-countries
…M-13999-Show-estimated-tax-for-taxable-countries
jonashendrickx
dismissed stale reviews from cturnbull-bitwarden and eliykat
via
cd566de
eliykat
previously approved these changes
Dec 19, 2024
Comment on lines
65
to
72
| validate = (): boolean => { | ||
| this.formGroup.markAllAsTouched(); | ||
| return this.formGroup.valid; | ||
| }; | ||
| validate(): boolean { | ||
| if (this.formGroup.dirty) { | ||
| this.formGroup.markAllAsTouched(); | ||
| return this.formGroup.valid; | ||
| } else { | ||
| return this.formGroup.valid; | ||
| } | ||
| } |
There was a problem hiding this comment.
🤔 I don't think component library forms require these kinds of workarounds (markAllAsTouched). You should just be able to check the formgroup's valid state. Maybe double check whether it's necessary and ask the design team.
cturnbull-bitwarden
previously approved these changes
Dec 27, 2024
cturnbull-bitwarden
previously approved these changes
Dec 30, 2024
JimmyVo16
approved these changes
Dec 31, 2024
cturnbull-bitwarden
approved these changes
Jan 2, 2025
jonashendrickx
deleted the
PM-13999-Show-estimated-tax-for-taxable-countries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13999
📔 Objective
AC-2476-deprecate-stripe-sources-apifeature flag in both enabled/disabled state.📸 Screenshots
Bot postal code & country fields are required. Note that the checkbox to include a tax id is removed.
It also listens for additional fields, such as plan, billing interval, additional storage, additional seats, machine accounts, etc.
Tax id codes are validated by our backend using regular expressions to resolve the tax id type based on the selected country:
Error messages by Stripe are also handled now, example is not available.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes