Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-4415] Improve form submissions capture for the notification bar #11517

Merged
merged 44 commits into from
Oct 16, 2024

Merge branch 'autofill/pm-8833-implement-on-page-autofill-menu-for-pa…

e0e207f
Select commit
Loading
Failed to load commit list.
Merged

[PM-4415] Improve form submissions capture for the notification bar #11517

Merge branch 'autofill/pm-8833-implement-on-page-autofill-menu-for-pa…
e0e207f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 16, 2024 in 0s

33.35% (+0.03%) compared to 2673f9b

View this Pull Request on Codecov

33.35% (+0.03%) compared to 2673f9b

Details

Codecov Report

Attention: Patch coverage is 67.74194% with 20 lines in your changes missing coverage. Please review.

Project coverage is 33.35%. Comparing base (2673f9b) to head (e0e207f).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...src/autofill/content/bootstrap-autofill-overlay.ts 0.00% 5 Missing ⚠️
...utofill/content/bootstrap-autofill-overlay-menu.ts 0.00% 4 Missing ⚠️
...browser/src/autofill/content/bootstrap-autofill.ts 0.00% 3 Missing ⚠️
...src/autofill/background/notification.background.ts 60.00% 2 Missing ⚠️
...ill/background/overlay-notifications.background.ts 81.81% 0 Missing and 2 partials ⚠️
...ontent/bootstrap-autofill-overlay-notifications.ts 0.00% 2 Missing ⚠️
...wser/src/autofill/background/overlay.background.ts 0.00% 1 Missing ⚠️
...utofill/services/dom-element-visibility.service.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                                             Coverage Diff                                              @@
##           autofill/pm-8833-implement-on-page-autofill-menu-for-password-generation   #11517      +/-   ##
============================================================================================================
+ Coverage                                                                     33.31%   33.35%   +0.03%     
============================================================================================================
  Files                                                                          2779     2779              
  Lines                                                                         86586    86607      +21     
  Branches                                                                      16506    16510       +4     
============================================================================================================
+ Hits                                                                          28848    28884      +36     
+ Misses                                                                        55463    55453      -10     
+ Partials                                                                       2275     2270       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov