[PM-4415] Improve form submissions capture for the notification bar #11517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…antiation to ensure it can be used in the OverlayContentService
…ough anchor elements
…-on-forms-that-do-not-emit-submit
…inside-dialog-html-tag
…og-html-tag' into autofill/pm-4415-detect-password-submissions-on-forms-that-do-not-emit-submit
…ssword-generation' into autofill/pm-4415-detect-password-submissions-on-forms-that-do-not-emit-submit
…based on an update within the tab loading state
…ssword-generation' into autofill/pm-4415-detect-password-submissions-on-forms-that-do-not-emit-submit
…within OverlayBackground
…ssword-generation' into autofill/pm-4415-detect-password-submissions-on-forms-that-do-not-emit-submit
…ssword-generation' into autofill/pm-4415-detect-password-submissions-on-forms-that-do-not-emit-submit
… a message when creating a notification
… a message when creating a notification
… a message when creating a notification
…-on-forms-that-do-not-emit-submit
…ssword-generation' into autofill/pm-4415-detect-password-submissions-on-forms-that-do-not-emit-submit
added 3 commits
October 11, 2024 13:54
…t represent itself in the #top-layer
…og-html-tag' into autofill/pm-4415-detect-password-submissions-on-forms-that-do-not-emit-submit
…ssword-generation' into autofill/pm-4415-detect-password-submissions-on-forms-that-do-not-emit-submit
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## autofill/pm-8833-implement-on-page-autofill-menu-for-password-generation #11517 +/- ##
============================================================================================================
+ Coverage 33.31% 33.35% +0.03%
============================================================================================================
Files 2779 2779
Lines 86586 86607 +21
Branches 16506 16510 +4
============================================================================================================
+ Hits 28848 28884 +36
+ Misses 55463 55453 -10
+ Partials 2275 2270 -5 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
added 5 commits
October 14, 2024 09:50
cagonzalezcs
changed the title
…ssword-generation' into autofill/pm-4415-detect-password-submissions-on-forms-that-do-not-emit-submit
…ssword-generation' into autofill/pm-4415-detect-password-submissions-on-forms-that-do-not-emit-submit
…ssword-generation' into autofill/pm-4415-detect-password-submissions-on-forms-that-do-not-emit-submit
…ssword-generation' into autofill/pm-4415-detect-password-submissions-on-forms-that-do-not-emit-submit
…ssword-generation' into autofill/pm-4415-detect-password-submissions-on-forms-that-do-not-emit-submit
jprusik
approved these changes
Oct 16, 2024
cagonzalezcs
merged commit 31e49ba
into
autofill/pm-8833-implement-on-page-autofill-menu-for-password-generation
24 of 25 checks passed
cagonzalezcs
deleted the
autofill/pm-4415-detect-password-submissions-on-forms-that-do-not-emit-submit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-4415
📔 Objective
The purpose of these changes is to improve the form submission capture process for the notification bar. These changes incorporate some modifications to how we handle qualification of fields, along with checks to ensure we capture visible buttons when attempting to capture click events on a submission button.
We also incorporate logic that presents the notification to a user when a form redirects from one page to another on submission. This ensures that we are able to present the notification on the location where the user signed up, even if they trigger the notification from the redirected origin.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes