Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking โSign up for GitHubโ, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-3301] Login - Move incorrect username or password error to inline field error #11443
[PM-3301] Login - Move incorrect username or password error to inline field error #11443
Changes from 1 commit
af9483d
2d60073
af91d39
2b90cbb
d4213fb
d917426
fcf01fe
688a24b
97f9008
a5fec36
669585a
9b28a0e
2a58a69
621115a
0cd840e
983cee8
19acf12
48ffd0b
1ad35b0
d74561d
d279ae4
e190ca4
4f893e0
e8c4217
70d15fb
00a29b3
3636c72
3c68fb0
81a623d
bdd6f9f
4d1ab66
b564ff4
e8e5ec2
b997b60
40e2cb5
7d8886e
feb16c3
d098ee0
9588148
0826184
d76f483
ff53fee
b64552f
e2434ff
04ca091
0f62f07
8c78662
c597b92
167b246
e3219d2
b0f4ac1
234191e
96f31ec
f9dc912
c89eb92
677829f
0cf965c
8696330
6ffaeae
bb5f88f
7a4b83a
9cb64b5
e616218
350459f
de4b177
4012a6c
c446345
532d3ea
8fa5c55
80fd8bd
236c41e
4df7712
b799618
e076e94
66072f6
da18b42
d88606a
e0d4702
d49c044
0bb18eb
6bbbfcd
6d1d02a
54f0c0a
c37f726
9bb8409
d9f930d
74767b0
22eb2aa
9a6b1a9
e0eff02
3187a33
7767545
1206017
7f14851
a1b9216
309576f
588a7af
9a277d6
5628ad4
2e6e5a5
035e62e
60d1177
a97dc74
e607aa7
07f1419
4ead4ef
c062970
bf8312d
bb67f56
30af195
58d6770
b2a63e6
3140be2
fbb5e35
7190f4d
ea8cd09
79b2633
d1a0c2f
04fa618
8469e35
86a10f2
a104a92
ca0520c
4f11c2c
f42a391
2d5f4df
d47ffdf
bdc988c
f8f8bb5
c0d37bc
66536d4
9308a47
68f358b
f6d59dc
db7b45f
cead261
51e8614
0df9474
467d773
d1a5455
994e097
2bb89a4
5aec3e8
8975b60
57044a6
6e337e1
47ce605
6d980bf
982da46
3868dcb
90a24cb
ea68572
1b17ddc
9b20322
7533089
99ddbc9
3936ccd
72f07fe
a2fa009
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Unchanged files with check annotations Beta
Check warning on line 1 in apps/browser/src/auth/popup/login/extension-login.service.ts
apps/browser/src/auth/popup/login/extension-login.service.ts#L1
Check warning on line 3 in apps/browser/src/auth/popup/login/extension-login.service.ts
apps/browser/src/auth/popup/login/extension-login.service.ts#L3
Check warning on line 5 in apps/browser/src/auth/popup/login/extension-login.service.ts
apps/browser/src/auth/popup/login/extension-login.service.ts#L5
Check warning on line 7 in apps/browser/src/auth/popup/login/extension-login.service.ts
apps/browser/src/auth/popup/login/extension-login.service.ts#L7
Check warning on line 5 in apps/browser/src/popup/app-routing.module.ts
apps/browser/src/popup/app-routing.module.ts#L4-L5
Check warning on line 32 in apps/browser/src/popup/app-routing.module.ts
apps/browser/src/popup/app-routing.module.ts#L32
Check warning on line 5 in apps/desktop/src/app/app-routing.module.ts
apps/desktop/src/app/app-routing.module.ts#L4-L5
Check warning on line 21 in apps/web/src/app/auth/core/services/login/web-login.service.ts
apps/web/src/app/auth/core/services/login/web-login.service.ts#L16-L21
Check warning on line 24 in apps/web/src/app/auth/core/services/login/web-login.service.ts
apps/web/src/app/auth/core/services/login/web-login.service.ts#L24
Check warning on line 28 in apps/web/src/app/auth/core/services/login/web-login.service.ts
apps/web/src/app/auth/core/services/login/web-login.service.ts#L28
Check warning on line 32 in apps/web/src/app/auth/core/services/login/web-login.service.ts
apps/web/src/app/auth/core/services/login/web-login.service.ts#L32
Check warning on line 38 in apps/web/src/app/auth/core/services/login/web-login.service.ts
apps/web/src/app/auth/core/services/login/web-login.service.ts#L37-L38
Check warning on line 45 in apps/web/src/app/auth/core/services/login/web-login.service.ts
apps/web/src/app/auth/core/services/login/web-login.service.ts#L45
Check warning on line 49 in apps/web/src/app/auth/core/services/login/web-login.service.ts
apps/web/src/app/auth/core/services/login/web-login.service.ts#L49
Check warning on line 52 in apps/web/src/app/auth/core/services/login/web-login.service.ts
apps/web/src/app/auth/core/services/login/web-login.service.ts#L52
Check warning on line 60 in apps/web/src/app/auth/core/services/login/web-login.service.ts
apps/web/src/app/auth/core/services/login/web-login.service.ts#L60
Check warning on line 64 in apps/web/src/app/auth/core/services/login/web-login.service.ts
apps/web/src/app/auth/core/services/login/web-login.service.ts#L64
Check warning on line 4 in apps/web/src/app/oss-routing.module.ts
apps/web/src/app/oss-routing.module.ts#L4
Check warning on line 5 in libs/auth/src/angular/icons/index.ts
libs/auth/src/angular/icons/index.ts#L4-L5
Check warning on line 7 in libs/auth/src/angular/icons/index.ts
libs/auth/src/angular/icons/index.ts#L7
Check warning on line 1 in libs/auth/src/angular/icons/wave.icon.ts
libs/auth/src/angular/icons/wave.icon.ts#L1
Check warning on line 3 in libs/auth/src/angular/icons/wave.icon.ts
libs/auth/src/angular/icons/wave.icon.ts#L3
Check warning on line 15 in libs/auth/src/angular/index.ts
libs/auth/src/angular/index.ts#L15
Check warning on line 25 in libs/auth/src/angular/index.ts
libs/auth/src/angular/index.ts#L22-L25
Check warning on line 28 in libs/auth/src/angular/index.ts
libs/auth/src/angular/index.ts#L28
Check warning on line 42 in libs/auth/src/angular/index.ts
libs/auth/src/angular/index.ts#L40-L42
Check warning on line 47 in libs/auth/src/angular/index.ts
libs/auth/src/angular/index.ts#L45-L47
Check warning on line 50 in libs/auth/src/angular/index.ts
libs/auth/src/angular/index.ts#L50
Check warning on line 8 in libs/auth/src/angular/login/default-login.service.ts
libs/auth/src/angular/login/default-login.service.ts#L8
Check warning on line 11 in libs/auth/src/angular/login/default-login.service.ts
libs/auth/src/angular/login/default-login.service.ts#L10-L11
Check warning on line 15 in libs/auth/src/angular/login/default-login.service.ts
libs/auth/src/angular/login/default-login.service.ts#L15
Check warning on line 19 in libs/auth/src/angular/login/default-login.service.ts
libs/auth/src/angular/login/default-login.service.ts#L19
Check warning on line 23 in libs/auth/src/angular/login/default-login.service.ts
libs/auth/src/angular/login/default-login.service.ts#L23
Check warning on line 3 in libs/auth/src/angular/login/login-secondary-content.component.ts
libs/auth/src/angular/login/login-secondary-content.component.ts#L1-L3
Check warning on line 6 in libs/auth/src/angular/login/login-secondary-content.component.ts
libs/auth/src/angular/login/login-secondary-content.component.ts#L5-L6
Check warning on line 21 in libs/auth/src/angular/login/login-secondary-content.component.ts
libs/auth/src/angular/login/login-secondary-content.component.ts#L20-L21
Check warning on line 24 in libs/auth/src/angular/login/login-secondary-content.component.ts
libs/auth/src/angular/login/login-secondary-content.component.ts#L24
Check warning on line 5 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L1-L5
Check warning on line 8 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L7-L8
Check warning on line 15 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L14-L15
Check warning on line 19 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L18-L19
Check warning on line 31 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L21-L31
Check warning on line 33 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L33
Check warning on line 43 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L42-L43
Check warning on line 45 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L45
Check warning on line 47 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L47
Check warning on line 51 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L50-L51
Check warning on line 69 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L69
Check warning on line 71 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L71
Check warning on line 74 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L73-L74
Check warning on line 77 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L77
Check warning on line 83 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L79-L83
Check warning on line 85 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L85
Check warning on line 95 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L95
Check warning on line 99 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L99
Check warning on line 110 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L109-L110
Check warning on line 114 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L113-L114
Check warning on line 136 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L136
Check warning on line 139 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L138-L139
Check warning on line 144 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L144
Check warning on line 147 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L147
Check warning on line 151 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L151
Check warning on line 156 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L156
Check warning on line 163 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L163
Check warning on line 167 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L166-L167
Check warning on line 170 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L170
Check warning on line 173 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L173
Check warning on line 177 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L177
Check warning on line 179 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L179
Check warning on line 196 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L196
Check warning on line 198 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L198
Check warning on line 201 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L201
Check warning on line 208 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L208
Check warning on line 211 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L210-L211
Check warning on line 216 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L215-L216
Check warning on line 233 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L231-L233
Check warning on line 240 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L240
Check warning on line 242 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L242
Check warning on line 248 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L248
Check warning on line 253 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L252-L253
Check warning on line 259 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L257-L259
Check warning on line 266 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L265-L266
Check warning on line 271 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L270-L271
Check warning on line 274 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L274
Check warning on line 276 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L276
Check warning on line 278 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L278
Check warning on line 283 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L283
Check warning on line 287 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L287
Check warning on line 305 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L301-L305
Check warning on line 312 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L311-L312
Check warning on line 316 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L316
Check warning on line 324 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L324
Check warning on line 328 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L327-L328
Check warning on line 333 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L332-L333
Check warning on line 337 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L336-L337
Check warning on line 339 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L339
Check warning on line 352 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L352
Check warning on line 356 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L356
Check warning on line 359 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L359
Check warning on line 365 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L365
Check warning on line 374 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L373-L374
Check warning on line 379 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L379
Check warning on line 382 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L382
Check warning on line 385 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L385
Check warning on line 388 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L388
Check warning on line 394 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L392-L394
Check warning on line 398 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L398
Check warning on line 401 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L401
Check warning on line 406 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L406
Check warning on line 409 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L409
Check warning on line 415 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L413-L415
Check warning on line 420 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L420
Check warning on line 426 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L425-L426
Check warning on line 428 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L428
Check warning on line 433 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L433
Check warning on line 436 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L436
Check warning on line 443 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L443
Check warning on line 453 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L453
Check warning on line 459 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L458-L459
Check warning on line 463 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L462-L463
Check warning on line 466 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L466
Check warning on line 469 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L469
Check warning on line 471 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L471
Check warning on line 477 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L477
Check warning on line 481 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L481
Check warning on line 486 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L486
Check warning on line 493 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L493
Check warning on line 496 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L496
Check warning on line 501 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L500-L501
Check warning on line 514 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L514
Check warning on line 519 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L519
Check warning on line 522 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L522
Check warning on line 525 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L525
Check warning on line 533 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L533
Check warning on line 536 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L536
Check warning on line 548 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L548
Check warning on line 556 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L556
Check warning on line 560 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L559-L560
Check warning on line 564 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L563-L564
Check warning on line 567 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L567
Check warning on line 569 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L569
Check warning on line 573 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L572-L573
Check warning on line 575 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L575
Check warning on line 581 in libs/auth/src/angular/login/login.component.ts
libs/auth/src/angular/login/login.component.ts#L581
Check warning on line 12 in libs/auth/src/angular/login/login.service.ts
libs/auth/src/angular/login/login.service.ts#L12