[PM-3301] Login - Move incorrect username or password error to inline field error #11443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues
Fixed Issues
|
…/pm-3301/move-incorrect-username-or-password-error-inline
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11443 +/- ##
==========================================
- Coverage 33.29% 33.07% -0.22%
==========================================
Files 2731 2790 +59
Lines 85549 86634 +1085
Branches 16318 16520 +202
==========================================
+ Hits 28480 28658 +178
- Misses 54811 55692 +881
- Partials 2258 2284 +26 ☔ View full report in Codecov by Sentry. |
alec-livefront
deleted the
auth/pm-3301/move-incorrect-username-or-password-error-inline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-3301?atlOrigin=eyJpIjoiM2Y4Y2ZjYzczOTAwNDZiNWJlZDVkYTcwYzYzYTc2MzYiLCJwIjoiaiJ9
📔 Objective
Move the "incorrect password" error from a toast to an inline error.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes