Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-283] Troubleshooting un-hardened Bitwarden Desktop App #11441

Closed
wants to merge 8 commits into from
+10 −6
Closed

[BRE-283] Troubleshooting un-hardened Bitwarden Desktop App #11441

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a56016c
update mas hardened runtime to true
Eeebru Oct 7, 2024
8dabbd4
comment testflight and slack notif branch checks
Eeebru Oct 7, 2024
b3496a8
Merge branch 'main' into DEVOPS-1424-Troubleshoot-un-hardened-Bitward…
Eeebru Dec 26, 2024
39efe24
add more entitlement permissions
Eeebru Dec 27, 2024
5aead6e
Merge main branch
Eeebru Dec 27, 2024
f7e5e31
uncomment PR target
Eeebru Dec 27, 2024
694a90c
update entitlements
Eeebru Dec 30, 2024
c956320
Merge branch 'main' into DEVOPS-1424-Troubleshoot-un-hardened-Bitward…
Eeebru Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-desktop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1176,7 +1176,7 @@ jobs:
id: testflight-deploy
if: |
github.event_name != 'pull_request_target'
&& (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/rc' || github.ref == 'refs/heads/hotfix-rc-desktop')
# && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/rc' || github.ref == 'refs/heads/hotfix-rc-desktop')
env:
APP_STORE_CONNECT_TEAM_ISSUER: ${{ secrets.APP_STORE_CONNECT_TEAM_ISSUER }}
APP_STORE_CONNECT_AUTH_KEY: 6TV9MKN3GP
Expand All @@ -1192,7 +1192,7 @@ jobs:
id: slack-message
if: |
github.event_name != 'pull_request_target'
&& (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/rc' || github.ref == 'refs/heads/hotfix-rc-desktop')
# && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/rc' || github.ref == 'refs/heads/hotfix-rc-desktop')
uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
with:
channel-id: C074F5UESQ0
Expand Down
2 changes: 1 addition & 1 deletion apps/desktop/electron-builder.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
"entitlements": "resources/entitlements.mas.plist",
"entitlementsInherit": "resources/entitlements.mas.inherit.plist",
"entitlementsLoginHelper": "resources/entitlements.mas.loginhelper.plist",
"hardenedRuntime": false,
"hardenedRuntime": true,
Eeebru marked this conversation as resolved.
Show resolved Hide resolved
"extendInfo": {
"LSMinimumSystemVersion": "12",
"ElectronTeamID": "LTZ2PFU5D6"
Expand Down
4 changes: 4 additions & 0 deletions apps/desktop/resources/entitlements.desktop_proxy.inherit.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,9 @@
<true/>
<key>com.apple.security.inherit</key>
<true/>
<key>com.apple.security.cs.allow-jit</key>
<true/>
<key>com.apple.security.cs.allow-unsigned-executable-memory</key>
<true/>
Eeebru marked this conversation as resolved.
Show resolved Hide resolved
</dict>
</plist>
4 changes: 4 additions & 0 deletions apps/desktop/resources/entitlements.desktop_proxy.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,9 @@
<array>
<string>LTZ2PFU5D6.com.bitwarden.desktop</string>
</array>
<key>com.apple.security.cs.allow-jit</key>
<true/>
<key>com.apple.security.cs.allow-unsigned-executable-memory</key>
<true/>
Eeebru marked this conversation as resolved.
Show resolved Hide resolved
</dict>
</plist>
2 changes: 1 addition & 1 deletion apps/desktop/resources/entitlements.mas.inherit.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<true/>
<key>com.apple.security.cs.allow-unsigned-executable-memory</key>
<true/>
Eeebru marked this conversation as resolved.
Show resolved Hide resolved
<key>com.apple.security.cs.disable-library-validation</key>
<key>com.apple.security.cs.allow-jit</key>
<true/>
<!--
<key>com.apple.developer.authentication-services.autofill-credential-provider</key>
Expand Down
4 changes: 4 additions & 0 deletions apps/desktop/resources/entitlements.mas.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,9 @@
<string>/Library/Application Support/Microsoft Edge Canary/NativeMessagingHosts/</string>
<string>/Library/Application Support/Vivaldi/NativeMessagingHosts/</string>
</array>
<key>com.apple.security.cs.allow-jit</key>
<true/>
<key>com.apple.security.cs.allow-unsigned-executable-memory</key>
<true/>
Eeebru marked this conversation as resolved.
Show resolved Hide resolved
</dict>
</plist>
Loading