Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-283] Troubleshooting un-hardened Bitwarden Desktop App #11441

Conversation

Eeebru
Copy link
Contributor

@Eeebru Eeebru commented Oct 7, 2024

🎟️ Tracking

📔 Objective

  • Harden the mas runtime config in apps/desktop/electron-builder.json

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.78%. Comparing base (77a2b24) to head (c956320).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11441   +/-   ##
=======================================
  Coverage   33.77%   33.78%           
=======================================
  Files        2912     2912           
  Lines       90747    90747           
  Branches    17165    17165           
=======================================
+ Hits        30648    30655    +7     
+ Misses      57710    57703    -7     
  Partials     2389     2389           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Logo
Checkmarx One – Scan Summary & Details2637d69e-26d9-41a8-97c5-b928fed094bd

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html: 15

@Eeebru Eeebru requested a review from a team as a code owner October 7, 2024 15:47
.github/workflows/build-desktop.yml Outdated Show resolved Hide resolved
.github/workflows/build-desktop.yml Outdated Show resolved Hide resolved
apps/desktop/electron-builder.json Show resolved Hide resolved
@Eeebru Eeebru requested a review from a team as a code owner December 26, 2024 16:53
@Eeebru Eeebru requested a review from justindbaur December 26, 2024 16:53
@withinfocus withinfocus deleted the DEVOPS-1424-Troubleshoot-un-hardened-Bitwarden-Desktop-App-2 branch December 31, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants