[PM-9473] Add messaging for macOS passkey extension and desktop #10768

dani-garcia · 2024-08-28T14:21:01Z

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9473

📔 Objective

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov · 2024-08-28T17:46:44Z

Codecov Report

Attention: Patch coverage is 5.26316% with 144 lines in your changes missing coverage. Please review.

Project coverage is 33.47%. Comparing base (b046c49) to head (0c01337).
Report is 86 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...m/services/desktop-fido2-user-interface.service.ts	0.00%	50 Missing ⚠️
.../src/autofill/services/desktop-autofill.service.ts	0.00%	46 Missing ⚠️
...src/platform/main/autofill/native-autofill.main.ts	0.00%	23 Missing ⚠️
apps/desktop/src/autofill/preload.ts	0.00%	14 Missing ⚠️
apps/desktop/src/app/services/services.module.ts	0.00%	4 Missing ⚠️
...rc/platform/services/fido2/fido2-autofill-utils.ts	0.00%	3 Missing ⚠️
apps/browser/src/background/main.background.ts	0.00%	1 Missing ⚠️
apps/desktop/src/main.ts	0.00%	1 Missing ⚠️
.../fido2/fido2-user-interface.service.abstraction.ts	0.00%	1 Missing ⚠️
...ervices/fido2/noop-fido2-user-interface.service.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10768      +/-   ##
==========================================
- Coverage   33.49%   33.47%   -0.03%     
==========================================
  Files        2897     2916      +19     
  Lines       90351    91246     +895     
  Branches    17165    17357     +192     
==========================================
+ Hits        30262    30541     +279     
- Misses      57698    58299     +601     
- Partials     2391     2406      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-08-28T17:48:45Z

Checkmarx One – Scan Summary & Details – 8f3d2523-1b87-417f-b431-ce02e198d0ef

New Issues

Issue	Source File / Package	Checkmarx Insight
Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 514	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 502	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 496	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 580	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 564	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 670	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 657	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 646	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 644	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 645	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 656	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 653	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 647	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 643	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1108	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1127	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1145	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1074	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 819	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1126	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1126	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1128	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1128	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1144	Attack Vector
Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1144	Attack Vector
Client_JQuery_Deprecated_Symbols	/apps/cli/src/service-container/service-container.ts: 878	Attack Vector
Unpinned Actions Full Length Commit SHA	/build-web.yml: 337	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/build-web.yml: 385	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/build-web.yml: 306	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/build-web.yml: 227	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unprotected_Cookie	/apps/web/src/app/auth/sso.component.ts: 175	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1166
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 130
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 86
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 38
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 565
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1074
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1074
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1074
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 670
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 693
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 671
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 680
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 679
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 673
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 663
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 664
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1238
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1238
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1220
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1220
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 515
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1239
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1221
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 503
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 497
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1171
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 581
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 662
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 665
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 661
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1237
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1045
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1219
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 1221
	Unpinned Actions Full Length Commit SHA	/build-web.yml: 370
	Unpinned Actions Full Length Commit SHA	/build-web.yml: 339
	Unpinned Actions Full Length Commit SHA	/build-web.yml: 418
	Unpinned Actions Full Length Commit SHA	/build-web.yml: 230
	Unprotected_Cookie	/apps/web/src/app/auth/core/services/login/web-sso-component.service.ts: 19
	Unprotected_Cookie	/apps/web/src/app/auth/sso-v1.component.ts: 175
	Use_of_Broken_or_Risky_Cryptographic_Algorithm	/libs/key-management/src/user-asymmetric-key-regeneration/services/default-user-asymmetric-key-regeneration.service.ts: 66
	Use_of_Broken_or_Risky_Cryptographic_Algorithm	/libs/key-management/src/user-asymmetric-key-regeneration/services/default-user-asymmetric-key-regeneration.service.ts: 111

apps/desktop/desktop_native/core/src/ipc/client.rs

apps/desktop/macos/autofill-extension/Info.plist

dani-garcia · 2024-09-04T17:41:21Z

apps/desktop/macos/autofill-extension/CredentialProviderViewController.swift

+    //
+    // If instead I make this a static, the deinit gets called correctly after each request.
+    // I think we still might want a static regardless, to be able to reuse the connection if possible.
+    static let client: MacOsProviderClient = {


TODO: Investigate why deinit wasn't always called. Maybe we leave some request unanswered?

I remember having similar issues when I was working on Passkey Provider PoCs. I got the feeling that swift was really bad at keeping track of references and/or really eager to garbage collect objects that are still in use. If that is the issue here then it makes sense that putting it in a static variable solves it.

Long time ago though, so takes this with a pinch of salt

apps/desktop/src/app/app.component.ts

dani-garcia · 2024-09-04T17:43:42Z

apps/desktop/src/autofill/preload.ts

 import { Command } from "../platform/main/autofill/command";
 import { RunCommandParams, RunCommandResult } from "../platform/main/autofill/native-autofill.main";

 export default {
  runCommand: <C extends Command>(params: RunCommandParams<C>): Promise<RunCommandResult<C>> =>
    ipcRenderer.invoke("autofill.runCommand", params),
+
+  listenPasskeyRegistration: (


This is API just proxies the requests from NAPI to the renderer process, and we also pass a callback so the renderer can respond.

apps/desktop/src/platform/main/autofill/native-autofill.main.ts

dani-garcia · 2024-09-04T17:46:47Z

apps/desktop/src/platform/services/desktop-fido2-user-interface.service.ts

+  }: PickCredentialParams): Promise<{ cipherId: string; userVerified: boolean }> {
+    this.logService.warning("pickCredential", cipherIds, userVerification);
+
+    return { cipherId: cipherIds[0], userVerified: userVerification };


When doing assertion, the user already selected a cipher from the quicktype bar, so we've already set allowCredentialDescriptorList to that credential ID, which means cipherIds should only contain the correct value.

dani-garcia · 2024-09-04T17:48:29Z

apps/desktop/src/platform/services/native-autofill.renderer.service.ts

+
+      // TODO: For some reason the credentialId is passed as an empty array in the request, so we need to
+      // get it from the cipher. For that we use the recordIdentifier, which is the cipherId.
+      if (request.recordIdentifier && request.credentialId.length === 0) {


TODO: Check why the provideCredentialWithoutUserInteraction on the extension doesn't provide the credentialId. It's not a big deal because we have the cipher ID, but there's no reason why it's not returning it.

dani-garcia · 2024-09-04T17:49:47Z

apps/desktop/src/platform/services/native-autofill.renderer.service.ts

+    });
+  }
+
+  private convertRegistrationRequest(


I'd appreciate a second look at these four conversion methods, there's a few fields that are left undefined because the swift extension doesn't have related values, and some values I had to set myself.

Added some minor comments but other than that I think it looks good!

libs/common/src/platform/services/fido2/fido2-autofill-utils.ts

coroiu

Quality work! 💯

coroiu · 2024-09-06T12:07:20Z

apps/desktop/desktop_native/macos_provider/build.sh

question: would it have been easier to compile into a regular C compatible library and use C <> ObjC <> Swift interop? Mostly I'm just wondering if you considered that approach and if/why you decided against it

Oh ok nevermind, we get uniffi support. Do you think it would be worth to try and use this for the objective-c part?

In this case I mostly used it because we needed to deal with callbacks and holding a reference to the object from the swift side, so I avoided using C-interop because I was worried about representing those callbacks in plain C, and dealing with memory leaks and undefined behavior.

The objective-c part is simpler as it's just calling a couple of functions, so for that I think all the boilerplate from uniffi might be too much.

apps/desktop/desktop_native/macos_provider/src/assertion.rs

apps/desktop/desktop_native/macos_provider/src/lib.rs

coroiu · 2024-09-06T12:39:25Z

apps/desktop/desktop_native/macos_provider/src/lib.rs

+                                info!(
+                                    "Time to process request: {:?}",
+                                    request_start_time.elapsed()
+                                );


question: are you thinking we should keep this in production or was it just something we added do debug the slow requests?

Yeah this is mostly for debug purposes, I was waiting until the PR removing sync was merged to test it again.

That said it woulnd't hurt to leave it, either.

apps/desktop/desktop_native/macos_provider/src/lib.rs

apps/desktop/src/platform/services/native-autofill.renderer.service.ts

coroiu · 2024-09-06T14:08:23Z

apps/desktop/src/platform/services/native-autofill.renderer.service.ts

+        alg,
+        type: "public-key",
+      })),
+      // TODO: Marked as optional but needs to be defined?


optional in the client but apparently not optional in the authenticator, can't remember why 🤷, we can just leave it like this for now. Future macOS versions will provides this though

coroiu · 2024-09-06T14:09:28Z

apps/desktop/src/platform/services/native-autofill.renderer.service.ts

+      requireUserVerification:
+        request.userVerification === "required" || request.userVerification === "preferred",


question: can this ever be undefined? If yes, then that should be treated as preferred

It shouldn't ever be, this struct is coming from Rust and there UserVerification is not an optional field

coroiu · 2024-09-06T14:10:44Z

apps/desktop/src/platform/services/native-autofill.renderer.service.ts

+    });
+  }
+
+  private convertRegistrationRequest(


Added some minor comments but other than that I think it looks good!

libs/common/src/platform/services/fido2/fido2-autofill-utils.ts

libs/common/src/platform/services/fido2/fido2-client.service.ts

coltonhurst

@dani-garcia @coroiu thanks for all the hard work on this! I am still very new to many concepts being introduced here 😅

Mostly looks good, just a couple of questions.

apps/desktop/desktop_native/macos_provider/build.sh

libs/common/src/platform/services/fido2/fido2-client.service.ts

apps/browser/src/autofill/fido2/services/browser-fido2-user-interface.service.ts

apps/desktop/macos/autofill-extension/autofill_extension.entitlements

Co-authored-by: Colton Hurst <[email protected]>

coroiu

Approving my own changes, good job Andreas!

dani-garcia commented Sep 4, 2024

View reviewed changes

coroiu reviewed Sep 6, 2024

View reviewed changes

coroiu force-pushed the ps/PM-9035-desktop-build-logic-to-provide-credentials-to-os-on-sync branch from ed0cf93 to 0a0c3ef Compare November 15, 2024 11:32

dani-garcia force-pushed the ps/PM-9473-macos-passkey-desktop-messaging branch 2 times, most recently from 4c91e50 to 212519a Compare December 5, 2024 13:03

dani-garcia changed the base branch from ps/PM-9035-desktop-build-logic-to-provide-credentials-to-os-on-sync to ps/PM-9473-add-uniffi-to-extension December 5, 2024 13:04

dani-garcia force-pushed the ps/PM-9473-add-uniffi-to-extension branch 4 times, most recently from 9836079 to 030e138 Compare December 5, 2024 14:59

dani-garcia force-pushed the ps/PM-9473-macos-passkey-desktop-messaging branch from 212519a to fe2c6cd Compare December 5, 2024 15:02

dani-garcia force-pushed the ps/PM-9473-add-uniffi-to-extension branch from 030e138 to a4594f6 Compare December 5, 2024 15:03

dani-garcia force-pushed the ps/PM-9473-macos-passkey-desktop-messaging branch from fe2c6cd to 0c8e074 Compare December 5, 2024 15:29

dani-garcia commented Dec 5, 2024

View reviewed changes

libs/common/src/platform/services/fido2/fido2-client.service.ts Show resolved Hide resolved

dani-garcia force-pushed the ps/PM-9473-macos-passkey-desktop-messaging branch from 0c8e074 to 6262a59 Compare December 5, 2024 16:09

dani-garcia force-pushed the ps/PM-9473-add-uniffi-to-extension branch from a4594f6 to d20ded9 Compare December 6, 2024 16:35

dani-garcia force-pushed the ps/PM-9473-macos-passkey-desktop-messaging branch from 6262a59 to 6c50198 Compare December 6, 2024 16:37

dani-garcia force-pushed the ps/PM-9473-add-uniffi-to-extension branch from d20ded9 to cb2f7c3 Compare December 6, 2024 18:07

dani-garcia force-pushed the ps/PM-9473-macos-passkey-desktop-messaging branch from 6c50198 to 646c0bc Compare December 6, 2024 18:08

Add messaging for macos passkey provider

52a6760

dani-garcia force-pushed the ps/PM-9473-macos-passkey-desktop-messaging branch from 646c0bc to 52a6760 Compare December 9, 2024 10:29

dani-garcia changed the base branch from ps/PM-9473-add-uniffi-to-extension to main December 9, 2024 10:29

dani-garcia mentioned this pull request Dec 9, 2024

Create uniffi package and use it from the extension #10466

Closed

Merge branch 'main' into ps/PM-9473-macos-passkey-desktop-messaging

2da6680

dani-garcia marked this pull request as ready for review December 9, 2024 12:38

dani-garcia requested review from a team as code owners December 9, 2024 12:38

dani-garcia requested a review from justindbaur December 9, 2024 12:38

Merge branch 'main' into ps/PM-9473-macos-passkey-desktop-messaging

c594ff8

coroiu previously approved these changes Dec 11, 2024

View reviewed changes

coroiu requested review from coltonhurst and removed request for justindbaur December 11, 2024 12:20

fix: credential id conversion

d0e9209

coroiu dismissed their stale review via d0e9209 December 12, 2024 11:35

coltonhurst reviewed Dec 17, 2024

View reviewed changes

coroiu and others added 2 commits December 18, 2024 08:47

Make build.sh executable

d64c865

Co-authored-by: Colton Hurst <[email protected]>

chore: add TODO

0c01337

coroiu requested review from coroiu and coltonhurst December 18, 2024 08:40

coroiu approved these changes Dec 18, 2024

View reviewed changes

coltonhurst approved these changes Dec 18, 2024

View reviewed changes

coroiu merged commit 51f6594 into main Dec 19, 2024
71 checks passed

coroiu deleted the ps/PM-9473-macos-passkey-desktop-messaging branch December 19, 2024 08:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PM-9473] Add messaging for macOS passkey extension and desktop #10768

[PM-9473] Add messaging for macOS passkey extension and desktop #10768

dani-garcia commented Aug 28, 2024

codecov bot commented Aug 28, 2024 •

edited

Loading

github-actions bot commented Aug 28, 2024 •

edited

Loading

dani-garcia Sep 4, 2024

coroiu Sep 6, 2024

dani-garcia Sep 4, 2024

dani-garcia Sep 4, 2024

dani-garcia Sep 4, 2024

dani-garcia Sep 4, 2024

coroiu Sep 6, 2024

coroiu left a comment

coroiu Sep 6, 2024

coroiu Sep 6, 2024

dani-garcia Sep 6, 2024

coroiu Sep 6, 2024

dani-garcia Sep 6, 2024

coroiu Sep 6, 2024

coroiu Sep 6, 2024

dani-garcia Dec 9, 2024

coroiu Sep 6, 2024

coltonhurst left a comment

coroiu left a comment

		requireUserVerification:
		request.userVerification === "required" \|\| request.userVerification === "preferred",

[PM-9473] Add messaging for macOS passkey extension and desktop #10768

[PM-9473] Add messaging for macOS passkey extension and desktop #10768

Conversation

dani-garcia commented Aug 28, 2024

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

🦮 Reviewer guidelines

codecov bot commented Aug 28, 2024 • edited Loading

Codecov Report

github-actions bot commented Aug 28, 2024 • edited Loading

New Issues

Fixed Issues

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coroiu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coltonhurst left a comment

Choose a reason for hiding this comment

coroiu left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 28, 2024 •

edited

Loading

github-actions bot commented Aug 28, 2024 •

edited

Loading