Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create uniffi package and use it from the extension #10466

Closed
wants to merge 1 commit into from

Conversation

dani-garcia
Copy link
Member

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Aug 9, 2024

Logo
Checkmarx One – Scan Summary & Details0068dc0b-be71-442b-9026-7f030f8b4371

No New Or Fixed Issues Found

@dani-garcia dani-garcia force-pushed the ps/PM-9473-add-uniffi-to-extension branch from 3108701 to e2b3738 Compare August 26, 2024 17:36
@coroiu coroiu changed the base branch from PM-9022-scaffold-the-extension-and-build-pipeline to ps/PM-9035-desktop-build-logic-to-provide-credentials-to-os-on-sync August 27, 2024 14:01
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.49%. Comparing base (9fcc4f0) to head (cb2f7c3).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...src/platform/main/autofill/native-autofill.main.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10466      +/-   ##
==========================================
- Coverage   33.49%   33.49%   -0.01%     
==========================================
  Files        2897     2897              
  Lines       90360    90362       +2     
  Branches    17163    17163              
==========================================
  Hits        30267    30267              
- Misses      57702    57704       +2     
  Partials     2391     2391              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coroiu coroiu force-pushed the ps/PM-9035-desktop-build-logic-to-provide-credentials-to-os-on-sync branch from ed0cf93 to 0a0c3ef Compare November 15, 2024 11:32
@dani-garcia dani-garcia force-pushed the ps/PM-9473-add-uniffi-to-extension branch 6 times, most recently from 030e138 to a4594f6 Compare December 5, 2024 15:03
Base automatically changed from ps/PM-9035-desktop-build-logic-to-provide-credentials-to-os-on-sync to main December 6, 2024 15:31
@dani-garcia dani-garcia force-pushed the ps/PM-9473-add-uniffi-to-extension branch from a4594f6 to d20ded9 Compare December 6, 2024 16:35
@dani-garcia dani-garcia force-pushed the ps/PM-9473-add-uniffi-to-extension branch from d20ded9 to cb2f7c3 Compare December 6, 2024 18:07
@dani-garcia
Copy link
Member Author

Combined the changes with #10768

@dani-garcia dani-garcia closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant