Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code smells #2704

Closed
wants to merge 1 commit into from
Closed

Fix code smells #2704

wants to merge 1 commit into from

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Dec 5, 2022

Note: this is identical to #2703, recreated to get around a permission issue related to the sonar-scan Github Actions workflow.

rewind is reserved
prefix increment dropped_count, i, next_block_num for efficiency increment from method call fetch_by_number() could cause undefined behavior parenthesis added for explicit operator precedence order of operations clarified
max 1 nested break

@litepresence @abitmore
delinting
41e1688 
`rewind` is reserved
prefix increment `dropped_count, i, next_block_num` for efficiency
increment from method call `fetch_by_number()`  could cause undefined behavior
parenthesis added for explicit operator precedence 
order of operations clarified
max 1 nested break
@abitmore abitmore added this to the 6.2.0 - Feature Release milestone Dec 5, 2022
@abitmore abitmore closed this Dec 5, 2022
@abitmore abitmore deleted the litepresence-patch-1 branch December 5, 2022 14:19
@abitmore
Copy link
Member Author

abitmore commented Dec 5, 2022

Superseded by #2705.

@abitmore abitmore removed this from the 6.2.0 - Feature Release milestone Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abitmore @litepresence