Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code smells #2703

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Conversation

litepresence
Copy link
Contributor

rewind is reserved
prefix increment dropped_count, i, next_block_num for efficiency
increment from method call fetch_by_number() could cause undefined behavior
parenthesis added for explicit operator precedence
order of operations clarified
max 1 nested break

`rewind` is reserved
prefix increment `dropped_count, i, next_block_num` for efficiency
increment from method call `fetch_by_number()`  could cause undefined behavior
parenthesis added for explicit operator precedence 
order of operations clarified
max 1 nested break
@abitmore abitmore changed the title delinting Fix code smells Dec 5, 2022
@abitmore abitmore added this to the 6.2.0 - Feature Release milestone Dec 5, 2022
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@abitmore abitmore changed the base branch from develop to litepresence-patch-1 December 5, 2022 14:09
@abitmore abitmore merged commit 41e1688 into bitshares:litepresence-patch-1 Dec 5, 2022
This was referenced Dec 5, 2022
@abitmore
Copy link
Member

abitmore commented Dec 5, 2022

Proceeding with #2705.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants