Remove empty pipeline validation

cli/run_util_pipeline_test.go

@@ -140,6 +140,15 @@ workflows:
   c: {}
 `
 
+const emptyPipeline = `
+format_version: '13'
+pipelines:
+  dag:
+    workflows: {}
+workflows:
+  a: {}
+`
+
 func TestValidation(t *testing.T) {
 	tests := []struct {
 		name    string
@@ -185,19 +194,8 @@ func TestValidation(t *testing.T) {
 			config: validStagedPipeline,
 		},
 		{
-			name: "The last pipeline is invalid",
-			config: `
-format_version: '13'
-pipelines:
-  pipeline1:
-    workflows:
-      a: {}
-  pipeline2:
-    workflows: {}
-workflows:
-  a: {}
-`,
-			wantErr: "failed to get Bitrise config (bitrise.yml) from base 64 data: Failed to parse bitrise config, error: pipeline (pipeline2) should have at least 1 stage or workflow",
+			name:   "Empty pipeline",
+			config: emptyPipeline,
 		},
 	}
 	for _, tt := range tests {

models/models_methods.go

@@ -559,8 +559,15 @@ func validatePipelines(config *BitriseDataModel) ([]string, error) {
 
 		if hasStages && hasWorkflows {
 			return pipelineWarnings, fmt.Errorf("pipeline (%s) has both stages and workflows", pipelineID)
-		} else if !hasStages && !hasWorkflows {
-			return pipelineWarnings, fmt.Errorf("pipeline (%s) should have at least 1 stage or workflow", pipelineID)
+		}
+
+		// A pipeline is considered valid if it has neither stages nor workflows.
+		// This is useful for the WFE to be able to save a pipeline that is not yet fully defined.
+		if !hasStages && !hasWorkflows {
+			warning := fmt.Sprintf("pipeline (%s) should have at least 1 stage or workflow", pipelineID)
+			pipelineWarnings = append(pipelineWarnings, warning)
+
+			continue
 		}
 
 		if hasStages {

models/models_methods_test.go

@@ -376,36 +376,6 @@ func TestValidateConfig(t *testing.T) {
 		require.Equal(t, "invalid pipeline ID (pi/id): doesn't conform to: [A-Za-z0-9-_.]", warnings[0])
 	}
 
-	t.Log("Invalid bitriseData - pipeline does not have any stages")
-	{
-		bitriseData := BitriseDataModel{
-			FormatVersion: "1.4.0",
-			Pipelines: map[string]PipelineModel{
-				"pipeline1": PipelineModel{
-					Stages: []StageListItemModel{},
-				},
-			},
-		}
-
-		warnings, err := bitriseData.Validate()
-		require.EqualError(t, err, "pipeline (pipeline1) should have at least 1 stage or workflow")
-		require.Equal(t, 0, len(warnings))
-	}
-
-	t.Log("Invalid bitriseData - pipeline does not have stages key defined")
-	{
-		bitriseData := BitriseDataModel{
-			FormatVersion: "1.4.0",
-			Pipelines: map[string]PipelineModel{
-				"pipeline1": PipelineModel{},
-			},
-		}
-
-		warnings, err := bitriseData.Validate()
-		require.EqualError(t, err, "pipeline (pipeline1) should have at least 1 stage or workflow")
-		require.Equal(t, 0, len(warnings))
-	}
-
 	t.Log("Invalid bitriseData - pipeline stage does not exist")
 	{
 		bitriseData := BitriseDataModel{
@@ -638,6 +608,72 @@ func TestValidateConfig(t *testing.T) {
 	}
 }
 
+func TestValidatePipelines(t *testing.T) {
+	tests := []struct {
+		name      string
+		config    string
+		wantWarns []string
+		wantErr   string
+	}{
+		{
+			name: "empty pipelines",
+			config: `
+format_version: 11
+default_step_lib_source: https://github.com/bitrise-io/bitrise-steplib.git
+
+pipelines:
+  pipeline1:
+    workflows: {}
+  pipeline2:
+    stages: []
+`,
+			wantWarns: []string{
+				"pipeline (pipeline1) should have at least 1 stage or workflow",
+				"pipeline (pipeline2) should have at least 1 stage or workflow",
+			},
+		},
+		{
+			name: "mixed pipeline",
+			config: `
+format_version: 11
+default_step_lib_source: https://github.com/bitrise-io/bitrise-steplib.git
+
+pipelines:
+  pipeline1:
+    workflows:
+      workflow1: {}
+    stages:
+    - stage1: {}
+stages:
+  stage1:
+    workflow1: {}
+workflows:
+  workflow1: {}
+`,
+			wantErr: "pipeline (pipeline1) has both stages and workflows",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			var config BitriseDataModel
+			require.NoError(t, yaml.Unmarshal([]byte(tt.config), &config))
+
+			warns, err := config.Validate()
+			if len(tt.wantWarns) > 0 {
+				require.Equal(t, tt.wantWarns, warns)
+			} else {
+				require.Empty(t, warns)
+			}
+
+			if tt.wantErr != "" {
+				require.EqualError(t, err, tt.wantErr)
+			} else {
+				require.NoError(t, err)
+			}
+		})
+	}
+}
+
 func TestValidateConfig_Containers(t *testing.T) {
 	tests := []struct {
 		name    string