Remove empty pipeline validation #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothszabi
force-pushed
the
allow-empty-pipelines
branch
from
56c5796 to
ba85434
Compare
zsolt-vicze
reviewed
Nov 12, 2024
| // A pipeline is considered valid if it has neither stages nor workflows. | ||
| // This is useful for the WFE to be able to save a pipeline that is not yet fully defined. | ||
| if !hasStages && !hasWorkflows { | ||
| continue |
There was a problem hiding this comment.
Did you consider adding a warning in this case?
There was a problem hiding this comment.
We discussed it and then I forgot to add it. Thanks for the reminder.
zsolt-vicze
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a PATCH version update
Context
Empty pipelines are valid so the WFE can save a not fully defined pipeline.