-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dependencies #1017
Update Dependencies #1017
Conversation
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imports can be optimized. Looks good otherwise :)
I like that you added a small delay to the spinning animation. I would probably go for 200 or 300 ms. It's not too long, but emphasizes the feedback of the gesture having been recognized a bit more. A minor detail though.
The pull-to-refresh icon appears on top of the tabs (see screenshot below), but it's been that way already, so I guess we can do that in a different PR ...
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
Done
I've now increased it to 300
See #1020 |
Purpose
Upgrade all dependencies, perform migrations and disable the linting issue we had.
Short description
LocalMinimumInteractiveComponentEnforcement
Checklist