Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies #1017

Merged
merged 7 commits into from
Sep 14, 2024
Merged

Update Dependencies #1017

merged 7 commits into from
Sep 14, 2024

Conversation

ArnyminerZ
Copy link
Member

Purpose

Upgrade all dependencies, perform migrations and disable the linting issue we had.

Short description

  • Upgrade all dependencies
  • Migrated pull to refresh
  • Removed linting issue
  • Migrated LocalMinimumInteractiveComponentEnforcement

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ ArnyminerZ added the refactoring Internal improvement of existing functions label Sep 11, 2024
@ArnyminerZ ArnyminerZ requested a review from rfc2822 September 11, 2024 09:56
@ArnyminerZ ArnyminerZ self-assigned this Sep 11, 2024
@ArnyminerZ ArnyminerZ linked an issue Sep 11, 2024 that may be closed by this pull request
2 tasks
@ArnyminerZ ArnyminerZ marked this pull request as ready for review September 11, 2024 09:56
@rfc2822 rfc2822 requested review from sunkup and removed request for rfc2822 September 11, 2024 11:27
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imports can be optimized. Looks good otherwise :)

I like that you added a small delay to the spinning animation. I would probably go for 200 or 300 ms. It's not too long, but emphasizes the feedback of the gesture having been recognized a bit more. A minor detail though.

The pull-to-refresh icon appears on top of the tabs (see screenshot below), but it's been that way already, so I guess we can do that in a different PR ...

image

Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ
Copy link
Member Author

Imports can be optimized

Done

I like that you added a small delay to the spinning animation. I would probably go for 200 or 300 ms. It's not too long, but emphasizes the feedback of the gesture having been recognized a bit more. A minor detail though.

I've now increased it to 300

The pull-to-refresh icon appears on top of the tabs (see screenshot below), but it's been that way already, so I guess we can do that in a different PR ...

See #1020

@ArnyminerZ ArnyminerZ requested a review from sunkup September 13, 2024 10:35
@rfc2822 rfc2822 merged commit cf60928 into main-ose Sep 14, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 1009-update-dependencies branch September 14, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies
3 participants