Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull to refresh indicator appears on top of tabs #1020

Closed
2 tasks done
ArnyminerZ opened this issue Sep 13, 2024 · 2 comments · Fixed by #1028
Closed
2 tasks done

Pull to refresh indicator appears on top of tabs #1020

ArnyminerZ opened this issue Sep 13, 2024 · 2 comments · Fixed by #1028
Assignees
@ArnyminerZ
Labels
bug Something isn't working

Comments

@ArnyminerZ
Copy link
Member

Problem scope

  • I'm sure that this is a DAVx⁵ problem.

App version

  • I'm using the latest available DAVx⁵ version.

Android version and device/firmware type

No response

Steps to reproduce

  1. Open an account in DAVX⁵
  2. Start pulling from the top so that pull to refresh shows on the screen
  3. It appears over the top tabs

Actual result

Screenshot

image

Expected result

It should appear below the tabs.

Further info

#1017 (review)
@ArnyminerZ ArnyminerZ added the bug Something isn't working label Sep 13, 2024
@ArnyminerZ ArnyminerZ mentioned this issue Sep 13, 2024
Merged
4 tasks
@rfc2822
Copy link
Member

rfc2822 commented Sep 16, 2024

As fas I remember, I put it over the tabs to indicate that it affects all tabs / services. However it's true that then the tabs are covered ;) I think it's better to show it below the tabs, as described above.

@ArnyminerZ
Copy link
Member Author

Yeah... It makes sense, but then the UI is a bit cursed...

@ArnyminerZ ArnyminerZ linked a pull request Sep 16, 2024 that will close this issue
Moved pull-to-refresh indicator below tabs #1028
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in DAVx⁵ Releases Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArnyminerZ ArnyminerZ

Labels
bug Something isn't working
Projects
DAVx⁵ Releases
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moved pull-to-refresh indicator below tabs bitfireAT/davx5-ose
2 participants
@rfc2822 @ArnyminerZ