Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return timestamp when last sync was launched #289

Merged

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Jun 16, 2023

This PR adds ability to return the timestamp when the last sync was launched to add this info to the layouts of the new design


Basic changes:

  • Implements dao getLastFinishedSyncQueueJob method
  • Returns mts when last sync was launched in response payload of signIn method
  • Adds test cases for lastSyncMts field

Request example:

{
  "method": "signIn",
  "auth": {
    "email": "[email protected]",
    "isSubAccount": false
  }
}

Response example:

{
  "jsonrpc": "2.0",
  "result": {
    "email": "[email protected]",
    "isSubAccount": false,
    "token": "e4afe3e3-1c96-450d-b8ec-5a604f664893",
    "shouldNotSyncOnStartupAfterUpdate": false,
    "authTokenTTLSec": null,
    "localUsername": null,
    "lastSyncMts": 1686902405802 // added field
  },
  "id": null
}

Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants