Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) Last sync time representation #863

Merged
merged 28 commits into from
Sep 20, 2024
Merged

(feature) Last sync time representation #863

merged 28 commits into from
Sep 20, 2024

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Sep 18, 2024 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1204852393443405/f

Description:

  • Implements Last Sync time handling and representation (approximately in hours) for the Reports app according to the improvement proposals

Preview:

last-sync-time-prev  
last-sync-time-flow.mov

Depends on:

@alexstotsky
Actualize sync constants
be89e94
@alexstotsky
Add setLastSyncTime action
4a2a991
@alexstotsky
Update sync reducers and initial state entries
14d2a68
@alexstotsky
Implement getLastSyncTime selector
cb8c96e
@alexstotsky
Implement getLastFinishedSyncMts method
a9b38f5
@alexstotsky
Implement refreshLastFinishedSyncMts saga
77ec08c
@alexstotsky
Cleanup
56edeb8
@alexstotsky
Add last sync time keys/descriptions
d4711c6
@alexstotsky
Improve refreshLastFinishedSyncMts saga errors handling
201dd35
@alexstotsky
Implement last sync time handling on auth success
5dcab30
@alexstotsky
[wip] Last sync time header section
71ee2fe
@alexstotsky
Add last sync time styling
e31f6e6
@alexstotsky
Actualize header styles export
115f3c3
@alexstotsky
Add last sync time to the header
ba8ab90
@alexstotsky
Improve last sync time styling
c9c9749
@alexstotsky
Update last sync keys/descriptions
868ba8e
@alexstotsky
Implement syncing state representation
c4402b2
@alexstotsky
Update locales
1f80299
@alexstotsky
Minor tweak
5f96667
@alexstotsky
Implement getLastSyncLabel helper
8d7a3d2
@alexstotsky
Update locales
00ef4e9
@alexstotsky
Optimize getLastSyncLabel helper
cb8840f
@alexstotsky
Improve syncing state label representation
c7c6fd3
@alexstotsky
Add last sync mts validation check
bd626a0
@alexstotsky
Optimize sync label getter, cleanup
f751adb
@alexstotsky
Adjust sync label styling
6fbc2be
@alexstotsky
Show last sync time only for the framework mode
64045fa
@alexstotsky
Lint fix
7434a31
@alexstotsky alexstotsky changed the title [WIP] (feature) Last sync time representation (feature) Last sync time representation Sep 18, 2024
@alexstotsky alexstotsky marked this pull request as ready for review September 18, 2024 10:05
ezewer
ezewer approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit eaa2081 into bitfinexcom:staging Sep 20, 2024
@alexstotsky alexstotsky deleted the show-last-sync-time branch September 20, 2024 09:03
This was referenced Sep 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexstotsky @ezewer @elvis-poggi