-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add estimated sync time to progress state #245
Merged
prdn
merged 13 commits into
bitfinexcom:beta
from
ZIMkaRU:feature/add-estimated-sync-time-to-progress-state
Jan 5, 2023
Merged
Add estimated sync time to progress state #245
prdn
merged 13 commits into
bitfinexcom:beta
from
ZIMkaRU:feature/add-estimated-sync-time-to-progress-state
Jan 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release version to master
Release version to master
ezewer
approved these changes
Jan 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds estimated sync time to the progress state and changes corresponding test coverage. The idea:
getSyncProgress
endpoint, check below a description of returning dataBreaking changes:
getSyncProgress
endpoint andemitProgress
WS event return the following data structure:instead of just
progress
value as it was beforeUI flow:
syncStartedAt
andspentTime
andleftTime
only when sync is going onnull
. So ifprogress
is not thenumber
don't show the estimated timesyncStartedAt
,spentTime
,leftTime
isnull
then, for that variable, showEstimating...
or something similar instead of justnull