Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(improvement) Estimated time info of the sync process #601

Merged
merged 18 commits into from
Jan 16, 2023
Merged

(improvement) Estimated time info of the sync process #601

merged 18 commits into from
Jan 16, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Jan 11, 2023 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1203549093603472/f

Description:

  • Adds estimated time info of the synchronization process
  • Improves sync progress handling

Preview:

estimated._sync_time.mov

@alexstotsky alexstotsky marked this pull request as ready for review January 11, 2023 14:14
@alexstotsky alexstotsky changed the title [WIP] (improvement) Estimated time info of the sync process (improvement) Estimated time info of the sync process Jan 11, 2023
ezewer
ezewer requested changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but can we parse the time to be displayed as minutes and seconds instead than ms please?

@alexstotsky alexstotsky requested a review from ezewer January 12, 2023 10:42
ezewer
ezewer approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@prdn prdn merged commit acc217f into bitfinexcom:beta Jan 16, 2023
@alexstotsky alexstotsky deleted the estimated-sync-time branch January 17, 2023 14:36
@ZIMkaRU ZIMkaRU mentioned this pull request Jan 18, 2023
Merged
@ezewer ezewer mentioned this pull request Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexstotsky @ezewer @prdn