-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PDF reports #347
Merged
ezewer
merged 94 commits into
bitfinexcom:staging
from
ZIMkaRU:feature/add-support-for-pdf-reports
Feb 20, 2024
Merged
Add support for PDF reports #347
ezewer
merged 94 commits into
bitfinexcom:staging
from
ZIMkaRU:feature/add-support-for-pdf-reports
Feb 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release version to master
This was referenced Feb 16, 2024
1 task
ezewer
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
1 task
This was referenced Mar 6, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
PDF
reportsThis PR doesn't bring breaking changes for compatibility with the current UI implementation. Everything should work as earlier. And adds the migration step for using api methods of report file generation:
After several release iterations and UI migration, deprecated methods will be removed
Basic changes:
report-files
folder instead ofcsv
Grenache
service for pdf generation for the online part of the appElectronjs
using the native api ofChromium
Inter
fonts for PDFHow PDF generation works
For PDF generation uses browser emulation with printing HTML to PDF format. We have to use two approaches:
Grenache
microservice) with old browser emulationPhantomJS
html-pdf
lib being added to npm dependencyChromium
Feature has the following flow:
PUG
templates which provide flexibility with inheritance and mixinsPUG
template toHTML
+ inline CSS + inline fonts in base64 to have everything in one HTML stringRequest example where need to pass
isPDFRequired
flag:Request example with common
isPDFRequired
flag:Layout example