Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) Export to PDF for ledgers and tax reports #775

Merged
merged 27 commits into from
Feb 20, 2024
Merged

(feature) Export to PDF for ledgers and tax reports #775

merged 27 commits into from
Feb 20, 2024

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Feb 19, 2024 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1206483223565096/f

Description:

  • Implements exporting to PDF support for Ledgers and Tax reports in the app

Preview:

ledgers-pdf-export-flow.mov

ledger-pdf-export-req

Depends on:

prdn and others added 27 commits February 14, 2024 12:06
@prdn
Merge pull request bitfinexcom#770 from bitfinexcom/staging
640f4a9 
Release version to master
@alexstotsky
Add is pdf requred const
5dcc1dd
@alexstotsky
Implement export to pdf status setter
0851da8
@alexstotsky
Actualize query reducers handling cases, update init state
bd4b4df
@alexstotsky
Actualize movements entries props shape
f39defb
@alexstotsky
Add getIsPdfExportRequired selector
bed77c9
@alexstotsky
Implement isTaxReport checker
3174237
@alexstotsky
Actualize export keys/descriptions
15bf527
@alexstotsky
Unify export dialog title
87b114e
@alexstotsky
Actualize local status description
120c41d
@alexstotsky
Actualize query sagas flow for tax report exporting case
2bcdb5c
@alexstotsky
[wip]Export to pdf switcher
e5c8aca
@alexstotsky
Cleanup
5ee5891
@alexstotsky
Adjust pdf switcher positioning
6136fef
@alexstotsky
Implement swicthing pdf flow
c8c69b7
@alexstotsky
Actualize export, cleanup
a29ce40
@alexstotsky
Optimize pdf export switcher
b53095d
@alexstotsky
Actualize export methods names
c6f1c4c
@alexstotsky
Lint fix
71c1b6f
@alexstotsky
Implement export dialog helpers
61142ed
@alexstotsky
Enhance pdf switcher availability checking flow
c1b5c4b
@alexstotsky
Improve getShowPdfSwitcher checking flow
4aecc17
@alexstotsky
Actualize ledgers get export method
6a800eb
@alexstotsky
Update getOptions saga config for ledgers case
0cbbd15
@alexstotsky
Actualize result prop-types, improve linting
9e988cc
@alexstotsky
Cleanup
dface5e
@alexstotsky
Lint fix
a71ab06
@alexstotsky alexstotsky marked this pull request as ready for review February 19, 2024 10:52
ezewer
ezewer approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ezewer ezewer merged commit ee5aad2 into bitfinexcom:staging Feb 20, 2024
@alexstotsky alexstotsky deleted the pdf-export4tax branch February 20, 2024 10:31
This was referenced Mar 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn