Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(improvement) OTP login flow #780

Merged
merged 7 commits into from
Mar 5, 2024

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Mar 4, 2024

Task: https://app.asana.com/0/1163495710802945/1206749632170616/f

Description:

- after setting correct google auth key
- makes auto request (without pushing btn)
- then we get a response and enable auth btn (as proposed before)
- and have a delay until the full app launch
- and here the btn is not blocked and the user can potentially send the second otp request 
with the same google token

Solution: we should keep btn disabled until the successful auth will be completed

Depends on:

@alexstotsky alexstotsky marked this pull request as ready for review March 4, 2024 10:15
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit fdf94e3 into bitfinexcom:staging Mar 5, 2024
@alexstotsky alexstotsky deleted the improve-otp-login-flow branch March 5, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants