Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(improvement) 2FA auth flow #776

Merged
merged 6 commits into from
Mar 5, 2024
Merged

(improvement) 2FA auth flow #776

merged 6 commits into from
Mar 5, 2024

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Feb 21, 2024 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1206642403046367/f

Description:

  • Improves 2FA authorization flow according to this proposal
After the first push of the auth button, we should lock the button 
(till we get any response from this endpoint) to prevent sending several of the same requests

@alexstotsky alexstotsky marked this pull request as ready for review February 21, 2024 10:03
@alexstotsky alexstotsky mentioned this pull request Mar 4, 2024
Merged
1 task
ezewer
ezewer approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ezewer ezewer merged commit 8bb3ba4 into bitfinexcom:staging Mar 5, 2024
@alexstotsky alexstotsky deleted the upd-2fa-flow branch March 5, 2024 10:35
This was referenced Mar 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexstotsky @ezewer @elvis-poggi