Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature) Username/password auth support #622

Merged
merged 170 commits into from
Mar 28, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Mar 24, 2023

Task: https://app.asana.com/0/1163495710802945/1204001395929420/f

Description:

  • Implements username/password auth support with Two-Factor Authentication for simple users in a framework mode and corresponding logic to handle various Reports authorization flow-related specifics
  • Improves Reports login modal styling according to the actual theme

Preview:

usrname-pwd-2fa.-auth-flow.mov

Depends on:

@alexstotsky alexstotsky changed the base branch from master to beta March 24, 2023 11:20
@alexstotsky alexstotsky changed the title [WIP] (feature) Username/password auth support feature) Username/password auth support Mar 24, 2023
@alexstotsky alexstotsky changed the title feature) Username/password auth support (feature) Username/password auth support Mar 24, 2023
@alexstotsky alexstotsky marked this pull request as ready for review March 24, 2023 12:16
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants