Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of Logging variables limited to 256 #313

Closed
whoenig opened this issue Apr 20, 2018 · 0 comments
Closed

Number of Logging variables limited to 256 #313

whoenig opened this issue Apr 20, 2018 · 0 comments
Milestone
2018.10

Comments

@whoenig
Copy link
Contributor

whoenig commented Apr 20, 2018

The number of logging variables is currently limited to 256, because a uint8 is used as internal id in CMD_GET_INFO and CMD_GET_ITEM (see https://github.com/bitcraze/crazyflie-firmware/blob/master/src/modules/src/log.c#L238-L289). This is an issue, because the current firmware already uses ~240 logging variables.

An obvious fix is to switch to uint16 instead, but the question is on how to do that in a version-safe way for the various clients. Perhaps we can:

  • Add CMD_GET_INFO_V2 and CMD_GET_ITEM_V2 that use uint16
  • Let clients implement the new version
  • Remove the old CMD_GET_INFO and CMD_GET_ITEM functions in a later firmware version
@whoenig whoenig mentioned this issue Jun 21, 2018
Closed
whoenig added a commit to USC-ACTLab/crazyflie-firmware that referenced this issue Jun 23, 2018
@whoenig
Allow more than 256 logging vars/parameters
ec4355a 
This addresses the firmware side of issue bitcraze#313 by adding additional
CRTP commands (called V2) that uses 16 instead of 8bits for indexing.

This change keeps the old API the same, but caps the number of vars
to 255 to allow older clients to keep working. Eventually, the old
API should be removed.

This change reduced the possible length of variables by 1 byte,
which affected two variables whose name had to be shortened.

Tested with crazyflie_cpp commit 3eb3203. Other clients will need
similar changes to use more than the first 255 variables.
@whoenig whoenig mentioned this issue Jun 23, 2018
Merged
ataffanel added a commit to USC-ACTLab/crazyflie-firmware that referenced this issue Aug 7, 2018
@ataffanel
bitcraze#313: Bump CRTP protocol version to 4
1116d1f 
This indicates that a client can use the new log messages to list up
to 16K variables
@krichardsson krichardsson added this to the next-version milestone Oct 17, 2018
cafeciaojoe pushed a commit to cafeciaojoe/crazyflie-firmware that referenced this issue Sep 27, 2024
@krichardsson
bitcraze#313 Disable Anchor identification radio button when Crazyfli…
c634b03 
…e is in TDoA mode
cafeciaojoe pushed a commit to cafeciaojoe/crazyflie-firmware that referenced this issue Sep 27, 2024
@krichardsson
bitcraze#313 Flake8 corrections
0ccd964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2018.10
Development

No branches or pull requests
2 participants
@krichardsson @whoenig