Changed color of progressbar in log-config and changes column-headers #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the headers to display the ctype and the size of the type (in bytes).
… red once the config is full. Also added a text displaying how many bytes the configuration contains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The progress-bar now displays red once a log-config is too large and green otherwise.
The column-headers in the trees now display data-type and size (in bytes) instead of 2 different versions of types (pytype and ctype)
I couldn't reproduce issue #360 , it seems like the backend doesn't allow saving a log-config that's larger than 26 bytes