Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid log configurations size check #360

Closed
krichardsson opened this issue Dec 7, 2018 · 1 comment
Closed

Invalid log configurations size check #360

krichardsson opened this issue Dec 7, 2018 · 1 comment

Comments

@krichardsson
Copy link
Contributor

krichardsson commented Dec 7, 2018

When setting up log configurations it is possible to add log variables up to a certain limit. The limit is based on the packe size and the size of the chosen log variables, they must all fit into the packet.
The client checks this limit and it is only possible to save configurations that are OK.

There seems to be a problem with the size check though and configurations that are slightly too big can be saved. The result is that the CF rejects the config and unfortunately there is no feedback to the user, the end result is that no log data is sent to the client and no logs appear in the log window.

Size checks in the client is done in https://github.com/bitcraze/crazyflie-clients-python/blob/master/src/cfclient/ui/dialogs/logconfigdialogue.py#L119-L126

This issue is related to bitcraze/crazyflie-firmware#48 and bitcraze/crazyflie-firmware#120

@knmcguire knmcguire changed the title Invalid log configurations created byt the client Invalid log configurations size check Jun 26, 2020
@krichardsson
Copy link
Contributor Author

Can't be reproduced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant